Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix buffer index crashes #126

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Fix buffer index crashes #126

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad90606
Fix buffer index crashes
jojorne Jun 19, 2024
a7b794b
Append with line feed
jojorne Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/AvaloniaLSP/AvaloniaLanguageServer/Services/Buffer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,15 @@ public sealed class Buffer

public string? GetTextTillLine(Position position)
{
string[] lines = _text.Split(separator, StringSplitOptions.RemoveEmptyEntries);
var linesRange = string.Join(string.Empty, lines[0..position.Line]);
string lastLine = lines[position.Line];

return linesRange + lastLine.Substring(0, position.Character);
string[] lines = _text.Split(separator, StringSplitOptions.None);
string text = string.Join("\n", lines[..position.Line]);
string line = lines[position.Line][..position.Character];
return $"{text}\n{line}";
}

public string? GetLine(Position position)
{
string[] lines = _text.Split(separator, StringSplitOptions.RemoveEmptyEntries);
string[] lines = _text.Split(separator, StringSplitOptions.None);
return lines[position.Line];
}

Expand All @@ -27,4 +26,4 @@ public Buffer(string text)

readonly string _text;
private static readonly string[] separator = ["\n", "\r\n"];
}
}