-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various small additions #59
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll finish this review and give a hand with static typing when I get back home.
But I'm not sure why so much stuff needs to be moved around. Does it even reduce forward references (making it so methods are declared before they're used visually)? It makes the git history messier, harder to find and track why things were added/removed and by whom (by using the "blame" tool. Also easily creates conflicts.
Otherwise the functional changes seem fine. The graph changes are a good improvement.
At first this may seem like a complicated Merge Request, but if you check the commits individually I think you'll quickly realise these are very simple changes.