Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict port range #27

Merged
merged 4 commits into from
Sep 7, 2023
Merged

Restrict port range #27

merged 4 commits into from
Sep 7, 2023

Conversation

joakimr-axis
Copy link
Contributor

@joakimr-axis joakimr-axis commented Jul 27, 2023

Describe your changes

Let the ACAP framework choose the user to run as, and restrict the port range to allow setting non-privileged ports only (or there would be permission issues).

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@joakimr-axis joakimr-axis requested a review from a team as a code owner July 27, 2023 13:42
@joakimr-axis
Copy link
Contributor Author

Let's separate running as the ACAP framework determined user and restricting the port range to the user range, keeping the current setup with user/group set to sdk.

@joakimr-axis joakimr-axis changed the title Run as ACAP framework determined user & restrict port range Restrict port range Sep 7, 2023
manifest.json Outdated Show resolved Hide resolved
joakimr-axis and others added 3 commits September 7, 2023 15:19
Let the ACAP framework choose the user to run as, and restrict the port
range to allow setting non-privileged ports only (or there would be
permission issues).

Change-Id: Ib243eeb6f4f50f44fb3091d4300a70ff51fbefc2
Signed-off-by: Joakim Roubert <[email protected]>
Signed-off-by: Joakim Roubert <[email protected]>
Change-Id: I6c0e09362abee41e6b7b547064c4e8ea950b67b6
Signed-off-by: Joakim Roubert <[email protected]>
@joakimr-axis joakimr-axis force-pushed the joakimr-axis_restrictportrange branch from b55953e to cc27e14 Compare September 7, 2023 13:20
@joakimr-axis joakimr-axis merged commit d5fe8ea into main Sep 7, 2023
@joakimr-axis joakimr-axis deleted the joakimr-axis_restrictportrange branch September 7, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant