Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doSystemAndReleaseMatch to handle arm64 #53

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

fishfacemcgee
Copy link

Fixes #52

If a more conservative approach to the changes is preferred, I can do something like this instead:

private boolean doSystemAndReleaseMatch(String arch, String os) {
    return arch.equals(this.getArch()) && os.equals(this.getOs())
    || SystemUtils.IS_OS_MAC && os.equals("darwin");
}

My thinking is that the Mac condition was an attempt to handle Arm-based Macs, but, since Arm is being detected properly, it should no longer need a special case.

@alfespa17
Copy link
Member

Thank you @fishfacemcgee , I think it should work

@alfespa17 alfespa17 merged commit 24eb3aa into AzBuilder:master Oct 30, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARM64 Terraform cannot be downloaded if OS reports its arch as Aarch64
2 participants