fix: Sonar cloud issues (#1453)

AzBuilder · Oct 23, 2024 · e30c986 · e30c986
1 parent 9443124
commit e30c986
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/...ain/java/org/terrakube/api/plugin/storage/configuration/StorageTypeAutoConfiguration.java b/...ain/java/org/terrakube/api/plugin/storage/configuration/StorageTypeAutoConfiguration.java
@@ -64,7 +64,7 @@ public StorageTypeService terraformOutput(StreamingService streamingService, Sto
                 break;
             case AWS:
                 S3Client s3client;
-                if (awsStorageTypeProperties.getEndpoint() != "") {
+                if (awsStorageTypeProperties.getEndpoint() != null && !awsStorageTypeProperties.getEndpoint().isEmpty()) {
                     log.info("Creating AWS SDK with custom endpoint and custom credentials");
                     s3client = S3Client.builder()
                             .region(Region.AWS_GLOBAL)

diff --git a/...rg/terrakube/executor/plugin/tfoutput/configuration/TerraformOutputAutoConfiguration.java b/...rg/terrakube/executor/plugin/tfoutput/configuration/TerraformOutputAutoConfiguration.java
@@ -66,7 +66,7 @@ public TerraformOutput terraformOutput(TerraformOutputProperties terraformOutput
                     break;
                 case AwsTerraformOutputImpl:
                     S3Client s3client = null;
-                    if (awsTerraformOutputProperties.getEndpoint() != "") {
+                    if (awsTerraformOutputProperties.getEndpoint() != null && !awsTerraformOutputProperties.getEndpoint().isEmpty()) {
                         log.info("Creating AWS SDK with custom endpoint and custom credentials");
                         s3client = S3Client.builder()
                                 .region(Region.AWS_GLOBAL)

diff --git a/.../org/terrakube/executor/plugin/tfstate/configuration/TerraformStateAutoConfiguration.java b/.../org/terrakube/executor/plugin/tfstate/configuration/TerraformStateAutoConfiguration.java
@@ -76,7 +76,7 @@ public TerraformState terraformState(TerrakubeClient terrakubeClient, TerraformS
                 case AwsTerraformStateImpl:
                     S3Client s3client = null;
 
-                    if (awsTerraformStateProperties.getEndpoint() != "") {
+                    if (awsTerraformStateProperties.getEndpoint() != null && !awsTerraformStateProperties.getEndpoint().isEmpty()) {
                         log.info("Creating AWS with custom endpoint and custom credentials");
                         s3client = S3Client.builder()
                                 .credentialsProvider(StaticCredentialsProvider.create(getAwsBasicCredentials(awsTerraformStateProperties)))

diff --git a/...in/java/org/terrakube/registry/plugin/storage/configuration/StorageAutoConfiguration.java b/...in/java/org/terrakube/registry/plugin/storage/configuration/StorageAutoConfiguration.java
@@ -72,7 +72,7 @@ public StorageService terraformOutput(OpenRegistryProperties openRegistryPropert
                 break;
             case AwsStorageImpl:
                 S3Client s3client;
-                if (awsStorageServiceProperties.getEndpoint() != "") {
+                if (awsStorageServiceProperties.getEndpoint() != null && !awsStorageServiceProperties.getEndpoint().isEmpty()) {
                     log.info("Creating AWS SDK with custom endpoint and custom credentials");
                     s3client = S3Client.builder()
                             .region(Region.AWS_GLOBAL)