Submission to suggest a fix for issue : Add on-the-fly proof generation #26

[bbresearcher]

Description

Problem*

Submission to try help with a fix for issue : Add on-the-fly proof generation #26

Resolves

Summary*

Added dynamic test code to Starter.t.sol in test directory.

Additional Context

PR Checklist*

• [ x] I have tested the changes locally.
• I have formatted the changes with Prettier and/or cargo fmt on default settings.

[netlify]

‼️ Deploy request for noir-next-hardhat rejected.

Name	Link
🔨 Latest commit	a8fec9f

[signorecello]

Thanks for your contribution @bbresearcher.

Could you please just fix this CI? Seems like it wants the -ffi flag

[bbresearcher]

Apologies for that, I have made changes to add ffi permissions by default in the foundry.toml file.

[critesjosh]

@bbresearcher Have you tested this in with multiple tests?

@signorecello tried this earlier and there are some irresolvable race conditions (iirc) with writing to the Prover.toml with multiple tests. this can be resolved by running 1 test at a time I believe, you just might want to add that to the README.

[bbresearcher]

@critesjosh and @signorecello : I am trying to see if I can come up with a solution, my tests fail with 3 or 4 dynamic proof generations, I will test a few ways and then let you know if I was able to solve it, or if I am just going to add instructions in the README.

[bbresearcher]

Hi @critesjosh and @signorecello I have managed to find a way to resolve the race condition, please may I ask if you could verify that? I have cloned a clean version and followed the readme and it worked, I made sure my /tmp was cleaned of old artefacts as well.

[critesjosh]

Awesome! 🙌 I am on my phone but will test when I'm at my computer.

Just curious where you found the solution, do you have a link?

[bbresearcher]

@critesjosh I must be honest I came up with it by myself, I did not google anything. the initial idea was based on the tweet you linked and also how I deployed a vyper contract before in foundry but the race fix was just an idea

[critesjosh]

Ah even better!