added support for v2.0 #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmprieur
approved these changes
Mar 31, 2022
| TokenValidationParameters = new TokenValidationParameters | ||
| { | ||
| SaveSigninToken = true, | ||
| ValidAudiences = webApiConfig.ValidAudiences | ||
| ValidAudiences = webApiConfig.ValidAudiences, | ||
| ValidIssuers = CommonUtil.BuildValidIssuers(webApiConfig) |
There was a problem hiding this comment.
Did you consider using ValidateIssuer instead ? (and set it to the AadIssuerValidator)?
https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/blob/039d09b7bc4c1671e1c4093d5a62d307c2f96935/src/Microsoft.IdentityModel.Validators/AadIssuerValidator/AadIssuerValidator.cs#L155-L156
Same for the other PR, btw
There was a problem hiding this comment.
@jmprieur Thank you, I will check it
There was a problem hiding this comment.
thats what he will do next
kalyankrishna1
approved these changes
Mar 31, 2022
|
@jmprieur can we close it please? |
|
@aremo-ms : you want to close this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added valid issuers to help using v2.0 token