[js] Fix: Making ResponseCreateParams optional params optional. (#108)

Azure-Samples · Dec 17, 2024 · b7ac1f9 · b7ac1f9
1 parent 5e9fff2
commit b7ac1f9
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 22 deletions.
diff --git a/javascript/standalone/package-lock.json b/javascript/standalone/package-lock.json
diff --git a/javascript/standalone/package.json b/javascript/standalone/package.json
@@ -1,6 +1,6 @@
 {
   "name": "rt-client",
-  "version": "0.5.1",
+  "version": "0.5.2",
   "scripts": {
     "test": "vitest",
     "build": "rollup -c",

diff --git a/javascript/standalone/rollup.config.mjs b/javascript/standalone/rollup.config.mjs
@@ -8,7 +8,7 @@ import nodeResolve from "@rollup/plugin-node-resolve";
 import alias from "@rollup/plugin-alias";
 import replace from "@rollup/plugin-replace";
 
-import pkg from "./package.json" assert { type: "json" };
+import pkg from "./package.json" with { type: "json" };
 
 export default [
   {

diff --git a/javascript/standalone/src/models.ts b/javascript/standalone/src/models.ts
@@ -170,8 +170,8 @@ export interface ItemDeleteMessage extends ClientMessageBase {
 }
 
 export interface ResponseCreateParams {
-  commit: boolean;
-  cancel_previous: boolean;
+  commit?: boolean;
+  cancel_previous?: boolean;
   append_input_items?: Item[];
   input_items?: Item[];
   instructions?: string;

diff --git a/javascript/standalone/test/client.spec.ts b/javascript/standalone/test/client.spec.ts
@@ -232,11 +232,11 @@ describe.each([
         });
         const response = await client.generateResponse();
         expect(response).toBeDefined();
-        expect(response.id).toBeDefined();
-        expect(response.id!.length).toBeGreaterThan(0);
-        for await (const item of response) {
+        expect(response!.id).toBeDefined();
+        expect(response!.id!.length).toBeGreaterThan(0);
+        for await (const item of response!) {
           expect(item).toBeDefined();
-          expect(item.responseId).toBe(response.id);
+          expect(item.responseId).toBe(response!.id);
           expect(item.previousItemId).toBe(sentItem.id);
         }
       });
@@ -254,14 +254,15 @@ describe.each([
           ],
         });
         const response = await client.generateResponse();
-        await response.cancel();
+        expect(response).toBeDefined();
+        await response!.cancel();
 
         let itemCount = 0;
-        for await (const _item of response) {
+        for await (const _item of response!) {
           itemCount++;
         }
         expect(itemCount).toBe(0);
-        expect(["cancelled", "completed"].includes(response.status));
+        expect(["cancelled", "completed"].includes(response!.status));
       });
 
       it("items should properly be emitted for text in text out", async () => {
@@ -277,8 +278,9 @@ describe.each([
           ],
         });
         const response = await client.generateResponse();
+        expect(response).toBeDefined();
 
-        for await (const item of response) {
+        for await (const item of response!) {
           expect(item.type).toBe("message");
           assert(item.type === "message");
           for await (const part of item) {
@@ -309,8 +311,9 @@ describe.each([
           ],
         });
         const response = await client.generateResponse();
+        expect(response).toBeDefined();
 
-        for await (const item of response) {
+        for await (const item of response!) {
           expect(item.type).toBe("message");
           assert(item.type === "message");
           for await (const part of item) {
@@ -366,8 +369,9 @@ describe.each([
             ],
           });
           const response = await client.generateResponse();
+          expect(response).toBeDefined();
 
-          for await (const item of response) {
+          for await (const item of response!) {
             expect(item.type).toBe("function_call");
             assert(item.type === "function_call");
             expect(item.functionName).toBe("get_weather_by_location");
@@ -398,8 +402,9 @@ describe.each([
             ],
           });
           const response = await client.generateResponse();
+          expect(response).toBeDefined();
 
-          for await (const item of response) {
+          for await (const item of response!) {
             expect(item.type).toBe("function_call");
             assert(item.type === "function_call");
             expect(item.functionName).toBe("get_weather_by_location");
@@ -430,8 +435,9 @@ describe.each([
             ],
           });
           const response = await client.generateResponse();
+          expect(response).toBeDefined();
 
-          for await (const item of response) {
+          for await (const item of response!) {
             expect(item.type).toBe("function_call");
             assert(item.type === "function_call");
             expect(item.functionName).toBe("get_weather_by_location");
@@ -462,8 +468,9 @@ describe.each([
             ],
           });
           const response = await client.generateResponse();
+          expect(response).toBeDefined();
 
-          for await (const item of response) {
+          for await (const item of response!) {
             expect(item.type).toBe("function_call");
             assert(item.type === "function_call");
             expect(item.functionName).toBe("get_weather_by_location");