Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump windows base image 2024-11B for Windows 2019, 2022, and 23H2 #5229

Merged
merged 2 commits into from
Nov 13, 2024
Merged

feat: bump windows base image 2024-11B for Windows 2019, 2022, and 23H2 #5229

merged 2 commits into from
Nov 13, 2024

Conversation

timmy-wright
Copy link
Contributor

@timmy-wright timmy-wright commented Nov 7, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Upgrades the Windows base image for 2024-11B:

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@cameronmeissner cameronmeissner added windows VHD your change will be included in the following VHDs labels Nov 7, 2024
@AbelHu
Copy link
Member

AbelHu commented Nov 13, 2024

It is better to add PR description as #5039

@timmy-wright timmy-wright changed the title chore: non-sec fixes for windows 2024-11b feat: bump windows base image 2024-11B for Windows 2019, 2022, and 23H2 Nov 13, 2024
AbelHu
AbelHu approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@AbelHu AbelHu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR.

@timmy-wright timmy-wright changed the base branch from master to dev November 13, 2024 21:27
@timmy-wright timmy-wright enabled auto-merge (squash) November 13, 2024 21:29
@timmy-wright timmy-wright merged commit a3120c3 into dev Nov 13, 2024
14 checks passed
@timmy-wright timmy-wright deleted the timmy/win-2024-11b branch November 13, 2024 22:02
timmy-wright added a commit that referenced this pull request Nov 13, 2024
@timmy-wright
feat: bump windows base image 2024-11B for Windows 2019, 2022, and 23…
0791b64 
…H2 (#5229)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbelHu AbelHu AbelHu approved these changes

@juan-lee juan-lee Awaiting requested review from juan-lee juan-lee is a code owner

@cameronmeissner cameronmeissner Awaiting requested review from cameronmeissner cameronmeissner is a code owner

@UtheMan UtheMan Awaiting requested review from UtheMan UtheMan is a code owner

@ganeshkumarashok ganeshkumarashok Awaiting requested review from ganeshkumarashok ganeshkumarashok is a code owner

@anujmaheshwari1 anujmaheshwari1 Awaiting requested review from anujmaheshwari1 anujmaheshwari1 is a code owner

@AlisonB319 AlisonB319 Awaiting requested review from AlisonB319 AlisonB319 is a code owner

@Devinwong Devinwong Awaiting requested review from Devinwong Devinwong is a code owner

@lilypan26 lilypan26 Awaiting requested review from lilypan26 lilypan26 is a code owner

@junjiezhang1997 junjiezhang1997 Awaiting requested review from junjiezhang1997 junjiezhang1997 is a code owner

@jason1028kr jason1028kr Awaiting requested review from jason1028kr jason1028kr is a code owner

@djsly djsly Awaiting requested review from djsly djsly is a code owner

@phealy phealy Awaiting requested review from phealy phealy is a code owner

@r2k1 r2k1 Awaiting requested review from r2k1 r2k1 is a code owner

Assignees
No one assigned
Labels
VHD your change will be included in the following VHDs windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timmy-wright @AbelHu @cameronmeissner