-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Error from Get-AzOpsCurrentPrincipal #857
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefajers
changed the title
Silence Error from Get-AzOpsCurrentPrincipal
Handle Error from Get-AzOpsCurrentPrincipal
Feb 7, 2024
daltondhcp
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌭 ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
This PR bumps dependencies and adds logic to handle errors from
Get-AzOpsCurrentPrincipal
when performingInvoke-AzRestMethod
orGet-AzADServicePrincipal
.This is to better align with previous
Az.Resources
default behavior and avoid unintentional errors thrown when principal id cannot be resolved.Bumping dependencies.
Az.Accounts 2.15.1
Az.Resources 6.15.0
This PR fixes/adds/changes/removes
Initialize-AzOpsEnvironment.ps1
Get-AzOpsCurrentPrincipal.ps1
Breaking Changes
N/A
Testing Evidence
Manual tests for user, managed identity and default logic like with tokens have been performed.
As part of this Pull Request I have
main
branch