Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Template Content for Push Deployment in-memory #870

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

Jefajers
Copy link
Member

Overview/Summary

This PR changes how AzOps utilizes the template file during deployment and fixes #868.

New behavior:
New-AzOpsDeployment will first attempt to utilize a parameter $TemplateObject that contains the relevant template content as a hashtable. Only if this parameter $TemplateObject is missing will it attempt to read the template file content.

Current behavior:
New-AzOpsDeployment attempt to read the content of the template file and potentially lock it during read and deployment.

This PR fixes/adds/changes/removes

  1. Changes Invoke-AzOpsPush.ps1
  2. Changes New-AzOpsDeployment.ps1

Breaking Changes

  1. N/A

Testing Evidence

Tests have been performed that locks the template files destined for deployment prior to Invoke-AzOpsPush calls New-AzOpsDeployment and with this code change the module continues to execute successful deployments. Without the code change it fails due to file lock.

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@Jefajers Jefajers added the bug Something isn't working label Mar 28, 2024
@Jefajers Jefajers added this to the v2.6.1 milestone Mar 28, 2024
@Jefajers Jefajers requested review from a team as code owners March 28, 2024 11:31
Copy link
Contributor

@daltondhcp daltondhcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💉

@Jefajers Jefajers merged commit f3b5da7 into Azure:main Mar 28, 2024
4 checks passed
@Jefajers Jefajers deleted the parallelDeploymentFileLock branch March 28, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Parallel Deployments with Multiple Parameter Files fail with file in use
2 participants