Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Resource Existence Validation Error Logic #908

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

Jefajers
Copy link
Member

Overview/Summary

This PR adds Try and Catch logic to Get-AzOpsResource.ps1 to manage underlying Az.PowerShell changes in error handling.

Without this code change the module can throw during custom resource deletion $scriptCmd = {& $wrappedCmd @PSBoundParameters} due to -ErrorAction handling changes in depended modules.

This PR fixes/adds/changes/removes

  1. Changes Get-AzOpsResource.ps1
  2. Changes Strings.psd1

Breaking Changes

  1. N/A

Testing Evidence

Deployment and deletion of custom resources have been tested.

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@Jefajers Jefajers merged commit 7aa9b34 into Azure:main Dec 17, 2024
4 checks passed
@Jefajers Jefajers deleted the deletion branch December 17, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants