-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telemetry Draft #2504
Open
blueww
wants to merge
14
commits into
Azure:main
Choose a base branch
from
blueww:Telemetry
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Telemetry Draft #2504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueww
force-pushed
the
Telemetry
branch
2 times, most recently
from
November 18, 2024 08:36
2181576
to
bea85a2
Compare
blueww
force-pushed
the
Telemetry
branch
2 times, most recently
from
November 18, 2024 08:50
4fe9875
to
b154255
Compare
blueww
force-pushed
the
Telemetry
branch
2 times, most recently
from
December 2, 2024 08:55
049161c
to
3c9cd4a
Compare
blueww
commented
Dec 10, 2024
blueww
commented
Dec 10, 2024
blueww
commented
Dec 10, 2024
@@ -27,6 +28,7 @@ export default function endMiddleware( | |||
)}`, | |||
context.contextId | |||
); | |||
AzuriteTelemetryClient.TraceBlobRequest(context); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make AzuriteTelemetryClient as interface.
blueww
commented
Dec 10, 2024
blueww
commented
Dec 10, 2024
blueww
force-pushed
the
Telemetry
branch
3 times, most recently
from
December 10, 2024 09:44
e961059
to
7e073bb
Compare
blueww
force-pushed
the
Telemetry
branch
4 times, most recently
from
December 11, 2024 09:28
36c4a62
to
736eed5
Compare
blueww
force-pushed
the
Telemetry
branch
2 times, most recently
from
December 11, 2024 10:06
39f9f0a
to
f882fdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a draft PR for telemetry, code still need refine.
Thanks for contribution! Please go through following checklist before sending PR.
PR Branch Destination
main
branch.legacy-dev
branch.Always Add Test Cases
Make sure test cases are added to cover the code change.
Add Change Log
Add change log for the code change in
Upcoming Release
section inChangeLog.md
.Development Guideline
Please go to CONTRIBUTION.md for steps about setting up development environment and recommended Visual Studio Code extensions.