Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry Draft #2504

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Telemetry Draft #2504

wants to merge 14 commits into from

Conversation

blueww
Copy link
Member

@blueww blueww commented Nov 18, 2024

Just a draft PR for telemetry, code still need refine.

Thanks for contribution! Please go through following checklist before sending PR.

PR Branch Destination

  • For Azurite V3, please send PR to main branch.
  • For legacy Azurite V2, please send PR to legacy-dev branch.

Always Add Test Cases

Make sure test cases are added to cover the code change.

Add Change Log

Add change log for the code change in Upcoming Release section in ChangeLog.md.

Development Guideline

Please go to CONTRIBUTION.md for steps about setting up development environment and recommended Visual Studio Code extensions.

@blueww blueww added the Do Not Merge Don't merge the PR label Nov 18, 2024
@blueww blueww self-assigned this Nov 18, 2024
src/common/Telemetry.ts Dismissed Show dismissed Hide dismissed
@blueww blueww force-pushed the Telemetry branch 2 times, most recently from 2181576 to bea85a2 Compare November 18, 2024 08:36
src/common/Telemetry.ts Fixed Show fixed Hide fixed
@blueww blueww force-pushed the Telemetry branch 2 times, most recently from 4fe9875 to b154255 Compare November 18, 2024 08:50
@blueww blueww force-pushed the Telemetry branch 2 times, most recently from 049161c to 3c9cd4a Compare December 2, 2024 08:55
@@ -27,6 +28,7 @@ export default function endMiddleware(
)}`,
context.contextId
);
AzuriteTelemetryClient.TraceBlobRequest(context);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make AzuriteTelemetryClient as interface.

src/common/Telemetry.ts Outdated Show resolved Hide resolved
src/common/Telemetry.ts Outdated Show resolved Hide resolved
@blueww blueww force-pushed the Telemetry branch 3 times, most recently from e961059 to 7e073bb Compare December 10, 2024 09:44
@blueww blueww force-pushed the Telemetry branch 4 times, most recently from 36c4a62 to 736eed5 Compare December 11, 2024 09:28
@blueww blueww force-pushed the Telemetry branch 2 times, most recently from 39f9f0a to f882fdc Compare December 11, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge Don't merge the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant