Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip input_schema for hftransformersv2 back compat #88

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Skip input_schema for hftransformersv2 back compat #88

merged 3 commits into from
Apr 3, 2024

Conversation

wamartin-aml
Copy link
Contributor

No description provided.

@wamartin-aml wamartin-aml requested a review from a team as a code owner April 2, 2024 12:55
trangevi
trangevi previously approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@trangevi trangevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leaving a comment that I don't really approve of these changes, but the package is no longer really supported anyway, so whatever.

@wamartin-aml
lint
83ef743 
Signed-off-by: Walter Martin <[email protected]>
@wamartin-aml
only check for hftransformers if input arg is dict
c0a5b88 
Signed-off-by: Walter Martin <[email protected]>
@trangevi trangevi merged commit 78c4e9c into Azure:master Apr 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trangevi trangevi trangevi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wamartin-aml @trangevi