fix(vscode): Clean dependency installation folder before extracting content #6706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Current Behavior
Binaries dependency installation is not cleaning the folder if there is a previous installation, causing some issue while trying to extract the content from the new installation
New Behavior
Now we clean the folder and then extract the contents of the new installation, making it as a fresh installation and making sure none of the previous ones remains.
Impact of Change
Not a breaking change
Test Plan
Note
TEST - Is quite hard to test since vitest doesn't provide a way to create in-memory file system. This will come more handy once we implement e2e tests in vscode
Risk - Low risk as its fixing an ongoing issue
Screenshots or Videos (if applicable)
CleanShot.2025-02-28.at.15.22.25.mp4