[DRAFT] Scorers Flexible Dictionary Inputs #816
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlundeen2
reviewed
Mar 21, 2025
| self._prompt_target = chat_target | ||
| self.scorer_type = "float_scale" | ||
|
|
||
| likert_scale = yaml.safe_load(likert_scale_path.read_text(encoding="utf-8")) | ||
| if isinstance(likert_scale, Path): |
There was a problem hiding this comment.
Keep in mind the end goal where this needs to be easy as heck to use. I might do something like the system prompt can be either
- Paths to the yaml files, which may need to be a new object because there are often a couple of these. E.g. this could be
SystemPromptYamlPathswhich users can configure paths, and parameters - a string (just the direct system prompt)
- SeedPrompt? Could this also be related to the
SystemPromptYamlPathsobject, and reuse the parameters and how they are applied?
It might make sense to write this up in a one pager with how it might look :)
And if it's not one of those things, throw an exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding dictionary inputs for scorers to make this more flexible and adaptable
Tests and Documentation
Ran notebooks, fixing unit tests