-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Azure Firewall as an option - Bicep code development #499
Conversation
@yahanda thanks for your contribution, we will review it and update you. @jensheerin will ping you to make sure Bicep and TF AzFW code is aligned. cc: @moisesjgomez |
@yahanda please sync your fork/branch with Azure/main. |
@danycontre I just synced with the latest changes into my branch. Thanks. |
@yahanda Thank you for your contribution! Reviewing the PR and will let you know of any further updates |
Delete unused variables to avoid Bicep warnings Bicep linting
Hi @moisesjgomez, I have updated it based on your advice. I would like to ask you to review my branch.
Testing evidence |
Hi @danycontre, this doesn't seem to be merged yet. Can it be reopened? CC: @swathibhat1 |
Overview/Summary
https://learn.microsoft.com/en-us/azure/firewall/protect-azure-virtual-desktop?tabs=azure
the need for inspecting and filtering egress traffic from AVD, but isn't this function typically a part of platform landing zone and the 'network hub', so it is deployed as part of platform foundation (different subscriptions), rather than AVD landing zone
This PR fixes/adds/changes/removes
Breaking Changes
Testing Evidence
Tested from the linke here: https://portal.azure.com/#blade/Microsoft_Azure_CreateUIDef/CustomDeploymentBlade/uri/https%3A%2F%2Fraw.githubusercontent.com%2Fyahanda%2Favdaccelerator-bicep-edits%2Fmain%2Fworkload%2Farm%2Fdeploy-baseline.json/uiFormDefinitionUri/https%3A%2F%2Fraw.githubusercontent.com%2Fyahanda%2Favdaccelerator-bicep-edits%2Fmain%2Fworkload%2Fportal-ui%2Fportal-ui-baseline.json
The portal displays a new firewall option.
The deployment was successful.
Firewall and related resources successfully deployed.
As part of this Pull Request I have
.bicep
file/s I am adding/editing are using the latest API version possiblemain
branch