Support for complex AD domain join passwords #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete unused variables to avoid Bicep warnings Bicep linting
Remove unnecessary variables to avoid Bicep warnings Avoid duplication of file names by creating variables Bicep linting
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -182,7 +182,8 @@ | |||
|
|
|||
| Write-Log "Unmounting drive" | |||
| # Remove-PSDrive -Name $DriveLetter -Force | |||
| net use ${DriveLetter} /delete | |||
| # HACK: Disabled because it fails | |||
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
|
@moisesjgomez I discovered that this solution is still incomplete too. Single quotes in the password ( |
|
@SvenAelterman Got it thanks for the update. I've merged into a new feature branch for testing. If you are able to add this component please raise another PR. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
Wrap domain join password in
"in the script arguments and escape any"that might be in the password.This PR fixes/adds/changes/removes
|(and possibly other characters too) #515Breaking Changes
N/A
Testing Evidence
Successful deployment of FSLogix and MSIX storage accounts with AD domain join using a complex password containing
|,@,\,:, and many more.As part of this Pull Request I have
.bicepfile/s I am adding/editing are using the latest API version possiblemainbranch