-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microsoft Entra ID name update #560
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick observation, for the CARML modules, unless you've done other editing in the modules to make them custom, I'd say revert those specific changes and let this be an "upstream" problem that is presumably fixed with a future release of their modules. Just adjust your own code, not their modules. Future of CARML is weird anyhow with AVM coming up -- but that's a whole other topic :)
Agree, we will be updating CARML modules to AVM soon, but to your point, yes, we made local edits to the CARML modules, so they work in our use case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few tidy-ups. Nice work!
| [AAD scenarios](./AADscenario/readme.md) | This folder contains scenario root modules that deploy AVD with Microsoft Entra ID join session host. | | ||
| [AAD Zero Trust scenarios](./zerotrust/readme.md) | This folder contains scenario root modules that deploy AVD with Microsoft Entra ID join session host following zero trust principles. | | ||
| [EntraID scenarios](./AADscenario/readme.md) | This folder contains scenario root modules that deploy AVD with Microsoft Entra ID join session host. | | ||
| [EntraID Zero Trust scenarios](./zerotrust/readme.md) | This folder contains scenario root modules that deploy AVD with Microsoft Entra ID join session host following zero trust principles. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| [EntraID Zero Trust scenarios](./zerotrust/readme.md) | This folder contains scenario root modules that deploy AVD with Microsoft Entra ID join session host following zero trust principles. | | |
| [Zero Trust scenarios](./zerotrust/readme.md) | This folder contains scenario root modules that deploy AVD with Microsoft Entra ID join session host following zero trust principles. | |
# Grant users access to Microsoft Entra ID-joined VMs | ||
#https://learn.microsoft.com/en-us/azure/virtual-desktop/deploy-azure-ad-joined-vm#assign-user-access-to-host-pools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Grant users access to Microsoft Entra ID-joined VMs | |
#https://learn.microsoft.com/en-us/azure/virtual-desktop/deploy-azure-ad-joined-vm#assign-user-access-to-host-pools | |
# Grant users access to Microsoft Entra ID-joined virtual machines | |
# https://learn.microsoft.com/azure/virtual-desktop/azure-ad-joined-session-hosts#assign-user-access-to-host-pools |
Co-authored-by: Chad Kittel <[email protected]>
updating Co-authored-by: Chad Kittel <[email protected]>
Updating Co-authored-by: Chad Kittel <[email protected]>
Updating Co-authored-by: Chad Kittel <[email protected]>
Updating Co-authored-by: Chad Kittel <[email protected]>
Updating Co-authored-by: Chad Kittel <[email protected]>
Updating Co-authored-by: Chad Kittel <[email protected]>
Updating Co-authored-by: Chad Kittel <[email protected]>
Updating Co-authored-by: Chad Kittel <[email protected]>
Updating Co-authored-by: Chad Kittel <[email protected]>
Co-authored-by: Chad Kittel <[email protected]>
Co-authored-by: Chad Kittel <[email protected]>
Co-authored-by: Chad Kittel <[email protected]>
Co-authored-by: Chad Kittel <[email protected]>
Co-authored-by: Chad Kittel <[email protected]>
Co-authored-by: Chad Kittel <[email protected]>
Co-authored-by: Chad Kittel <[email protected]>
Co-authored-by: Chad Kittel <[email protected]>
Co-authored-by: Chad Kittel <[email protected]>
Co-authored-by: Chad Kittel <[email protected]>
Co-authored-by: Chad Kittel <[email protected]>
…elerator into entraid-name-update
…elerator into entraid-name-update
Updated code merged. |
Microsoft Entra ID name update
Overview/Summary
Replace this with a brief description of what this Pull Request fixes, changes, etc.
This PR fixes/adds/changes/removes
Breaking Changes
Testing Evidence
Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
As part of this Pull Request I have
.bicep
file/s I am adding/editing are using the latest API version possiblemain
branch