-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JCore-Add CMK option for Storage / ZT #717
Open
JCoreMS
wants to merge
41
commits into
Azure:main
Choose a base branch
from
JCoreMS:JCore-Accelerator-StgAddCMK-Nov2024
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for key vault role assignments
…or key vault role assignments
…or key vault role assignments
…d for key vault role assignments
… baseline deployment
…date schema URL in portal UI baseline
…ity with specified encryption permissions
…e to key-stracctname
…cryption keys and format key names in customer managed key
…y key definitions
…IdentityResourceId and update template hashes
… properties for storage services
… identity support for encryption
… for fslogix and msix zt config
…ust storage configuration and enhance tooltip description for clarity
…com/JCoreMS/avdaccelerator into JCore-Accelerator-StgAddCMK-Nov2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
This change incorporates updates to the baseline deployment to add an option in the Storage section of the UI for Zero Trust which then allows for an additional Key Vault to be deployed. Keys created for each storage account and Customer Managed Keys configured for each storage account.
This PR fixes/adds/changes/removes
Breaking Changes
Testing Evidence
Tested deployment in lab environment with multiple scenarios and successfully deployed each time to include the changes added with the option flag set.
As part of this Pull Request I have
.bicep
file/s I am adding/editing are using the latest API version possiblemain
branch