Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JCore-Add CMK option for Storage / ZT #717

Open
wants to merge 41 commits into
base: main
Choose a base branch
from

Conversation

JCoreMS
Copy link
Contributor

@JCoreMS JCoreMS commented Dec 3, 2024

Overview/Summary

This change incorporates updates to the baseline deployment to add an option in the Storage section of the UI for Zero Trust which then allows for an additional Key Vault to be deployed. Keys created for each storage account and Customer Managed Keys configured for each storage account.

This PR fixes/adds/changes/removes

  1. Adjusted UI definition for custom names - prefix regex set for 1-6 chars but validation mesg said 1-90.
  2. Adds check box for Zero Trust in Custom UI Storage section
  3. Code includes logic to handle and deploy additional key vault, keys and associates with existing identity and storage accounts.

Breaking Changes

  1. N/A

Testing Evidence

Tested deployment in lab environment with multiple scenarios and successfully deployed each time to include the changes added with the option flag set.

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • (AVD LZA Team Only) Associated it with relevant ADO Items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Docs etc.)

…cryption keys and format key names in customer managed key
…IdentityResourceId and update template hashes
…ust storage configuration and enhance tooltip description for clarity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants