Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dns-resolver] Add DNS resolver 2023-07-01-preview changes into azure cli extensions #8289

Merged

Conversation

jamesvoongms
Copy link
Member

@jamesvoongms jamesvoongms commented Nov 15, 2024

Hi team, the PR adds the new swagger additions from our 2023-07-01-preview version, this adds four new resources into the module

az dns-resolver policy
az dns-resolver policy dns-security-rule
az dns-resolver policy vnet-link
az dns-resolver domain-list

Corresponding aaz PR: Azure/aaz#627


Related command

az dns-resolver
az dns-resolver-domain-list
az dns-resolver-policy

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Nov 15, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️dns-resolver
rule cmd_name rule_message suggest_message
⚠️ 1009 - ParaPropRemove dns-resolver create cmd dns-resolver create update parameter dns_resolver_name: removed property id_part=name
⚠️ 1011 - SubgroupAdd dns-resolver domain-list sub group dns-resolver domain-list added
⚠️ 1009 - ParaPropRemove dns-resolver forwarding-rule create cmd dns-resolver forwarding-rule create update parameter forwarding_rule_name: removed property id_part=child_name_1
⚠️ 1009 - ParaPropRemove dns-resolver forwarding-rule create cmd dns-resolver forwarding-rule create update parameter ruleset_name: removed property id_part=name
⚠️ 1006 - ParaAdd dns-resolver forwarding-rule list cmd dns-resolver forwarding-rule list added parameter pagination_limit
⚠️ 1006 - ParaAdd dns-resolver forwarding-rule list cmd dns-resolver forwarding-rule list added parameter pagination_token
⚠️ 1006 - ParaAdd dns-resolver forwarding-rule update cmd dns-resolver forwarding-rule update added parameter generic_update_add
⚠️ 1006 - ParaAdd dns-resolver forwarding-rule update cmd dns-resolver forwarding-rule update added parameter generic_update_force_string
⚠️ 1006 - ParaAdd dns-resolver forwarding-rule update cmd dns-resolver forwarding-rule update added parameter generic_update_remove
⚠️ 1006 - ParaAdd dns-resolver forwarding-rule update cmd dns-resolver forwarding-rule update added parameter generic_update_set
⚠️ 1009 - ParaPropRemove dns-resolver forwarding-ruleset create cmd dns-resolver forwarding-ruleset create update parameter dns_forwarding_ruleset_name: removed property id_part=name
⚠️ 1006 - ParaAdd dns-resolver forwarding-ruleset list-by-virtual-network cmd dns-resolver forwarding-ruleset list-by-virtual-network added parameter pagination_limit
⚠️ 1006 - ParaAdd dns-resolver forwarding-ruleset list-by-virtual-network cmd dns-resolver forwarding-ruleset list-by-virtual-network added parameter pagination_token
⚠️ 1006 - ParaAdd dns-resolver forwarding-ruleset update cmd dns-resolver forwarding-ruleset update added parameter generic_update_add
⚠️ 1006 - ParaAdd dns-resolver forwarding-ruleset update cmd dns-resolver forwarding-ruleset update added parameter generic_update_force_string
⚠️ 1006 - ParaAdd dns-resolver forwarding-ruleset update cmd dns-resolver forwarding-ruleset update added parameter generic_update_remove
⚠️ 1006 - ParaAdd dns-resolver forwarding-ruleset update cmd dns-resolver forwarding-ruleset update added parameter generic_update_set
⚠️ 1009 - ParaPropRemove dns-resolver inbound-endpoint create cmd dns-resolver inbound-endpoint create update parameter dns_resolver_name: removed property id_part=name
⚠️ 1009 - ParaPropRemove dns-resolver inbound-endpoint create cmd dns-resolver inbound-endpoint create update parameter inbound_endpoint_name: removed property id_part=child_name_1
⚠️ 1006 - ParaAdd dns-resolver inbound-endpoint list cmd dns-resolver inbound-endpoint list added parameter pagination_limit
⚠️ 1006 - ParaAdd dns-resolver inbound-endpoint list cmd dns-resolver inbound-endpoint list added parameter pagination_token
⚠️ 1006 - ParaAdd dns-resolver inbound-endpoint update cmd dns-resolver inbound-endpoint update added parameter generic_update_add
⚠️ 1006 - ParaAdd dns-resolver inbound-endpoint update cmd dns-resolver inbound-endpoint update added parameter generic_update_force_string
⚠️ 1006 - ParaAdd dns-resolver inbound-endpoint update cmd dns-resolver inbound-endpoint update added parameter generic_update_remove
⚠️ 1006 - ParaAdd dns-resolver inbound-endpoint update cmd dns-resolver inbound-endpoint update added parameter generic_update_set
⚠️ 1006 - ParaAdd dns-resolver list-by-virtual-network cmd dns-resolver list-by-virtual-network added parameter pagination_limit
⚠️ 1006 - ParaAdd dns-resolver list-by-virtual-network cmd dns-resolver list-by-virtual-network added parameter pagination_token
⚠️ 1009 - ParaPropRemove dns-resolver outbound-endpoint create cmd dns-resolver outbound-endpoint create update parameter dns_resolver_name: removed property id_part=name
⚠️ 1009 - ParaPropRemove dns-resolver outbound-endpoint create cmd dns-resolver outbound-endpoint create update parameter outbound_endpoint_name: removed property id_part=child_name_1
⚠️ 1006 - ParaAdd dns-resolver outbound-endpoint list cmd dns-resolver outbound-endpoint list added parameter pagination_limit
⚠️ 1006 - ParaAdd dns-resolver outbound-endpoint list cmd dns-resolver outbound-endpoint list added parameter pagination_token
⚠️ 1006 - ParaAdd dns-resolver outbound-endpoint update cmd dns-resolver outbound-endpoint update added parameter generic_update_add
⚠️ 1006 - ParaAdd dns-resolver outbound-endpoint update cmd dns-resolver outbound-endpoint update added parameter generic_update_force_string
⚠️ 1006 - ParaAdd dns-resolver outbound-endpoint update cmd dns-resolver outbound-endpoint update added parameter generic_update_remove
⚠️ 1006 - ParaAdd dns-resolver outbound-endpoint update cmd dns-resolver outbound-endpoint update added parameter generic_update_set
⚠️ 1011 - SubgroupAdd dns-resolver policy sub group dns-resolver policy added
⚠️ 1006 - ParaAdd dns-resolver update cmd dns-resolver update added parameter generic_update_add
⚠️ 1006 - ParaAdd dns-resolver update cmd dns-resolver update added parameter generic_update_force_string
⚠️ 1006 - ParaAdd dns-resolver update cmd dns-resolver update added parameter generic_update_remove
⚠️ 1006 - ParaAdd dns-resolver update cmd dns-resolver update added parameter generic_update_set
⚠️ 1009 - ParaPropRemove dns-resolver vnet-link create cmd dns-resolver vnet-link create update parameter ruleset_name: removed property id_part=name
⚠️ 1009 - ParaPropRemove dns-resolver vnet-link create cmd dns-resolver vnet-link create update parameter virtual_network_link_name: removed property id_part=child_name_1
⚠️ 1006 - ParaAdd dns-resolver vnet-link list cmd dns-resolver vnet-link list added parameter pagination_limit
⚠️ 1006 - ParaAdd dns-resolver vnet-link list cmd dns-resolver vnet-link list added parameter pagination_token

Copy link

Hi @jamesvoongms,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @jamesvoongms,
Since the current milestone time is less than 7 days, this pr may not catch up with this release.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 15, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Nov 15, 2024

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 15, 2024
@jamesvoongms jamesvoongms force-pushed the feature-dns-resolver-2023-07-01-additions branch from 510199f to f7e540f Compare November 15, 2024 02:59
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 15, 2024
@necusjz
Copy link
Member

necusjz commented Nov 15, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jamesvoongms
Copy link
Member Author

/azp run

Copy link

Commenter does not have sufficient privileges for PR 8289 in repo Azure/azure-cli-extensions

@necusjz
Copy link
Member

necusjz commented Nov 15, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@necusjz
Copy link
Member

necusjz commented Nov 15, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@necusjz necusjz merged commit 4ebc299 into Azure:main Nov 15, 2024
21 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ dns-resolver ] : https://dev.azure.com/azclitools/release/_build/results?buildId=206669&view=results

ksayid pushed a commit to SethHollandsworth/azure-cli-extensions that referenced this pull request Jan 8, 2025
… cli extensions (Azure#8289)

* Add DNS resolver 2023-07-01-preview changes into azure cli extensions

* Re-run test commands and switch to only one command group

* Change parameter names to be shorter

* Fix setup.py name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants