{Core} Stop using legacy base64.decodebytes
#30464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiasli
requested review from
evelyn-ys,
jsntcy,
kairu-ms,
zhoxing-ms,
calvinhzy,
necusjz and
bebound
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
|
microsoft-github-policy-service
bot
requested review from
yonzhan and
yanzhudd
microsoft-github-policy-service
bot
added
the
Compute
jiasli
commented
Dec 4, 2024
|
|
||
| parts = openssh_pubkey.split() | ||
| if len(parts) < 2: | ||
| return False | ||
| key_type = parts[0] | ||
| key_string = parts[1] | ||
|
|
||
| data = base64_decode(key_string.encode()) # pylint:disable=deprecated-method | ||
| data = base64.b64decode(key_string) |
There was a problem hiding this comment.
base64.b64decode() takes str input:
https://docs.python.org/3/library/base64.html#base64.b64decode
base64.b64decode(s, altchars=None, validate=False)
Decode the Base64 encoded bytes-like object or ASCII string s and return the decoded bytes.
jiasli
changed the title
base64.decodebytesbase64.decodebytes
zhoxing-ms
approved these changes
Dec 9, 2024
|
I think |
yanzhudd
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az vm createaz aks createDescription
Created from #30451 (comment)
Stop using legacy
base64.decodebytes.https://docs.python.org/3/library/base64.html