[Role] BREAKING CHANGE: az role assignment delete: Stop deleting all role assignments by default
#30470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
|
jiasli
commented
Dec 5, 2024
| @@ -355,7 +355,7 @@ class PrincipalType(str, Enum): | |||
| 'JSON description.') | |||
|
|
|||
| with self.argument_context('role assignment delete') as c: | |||
| c.argument('yes', options_list=['--yes', '-y'], action='store_true', help='Continue to delete all assignments under the subscription') | |||
| c.argument('yes', options_list=['--yes', '-y'], action='store_true', help='Currently no-op.') | |||
There was a problem hiding this comment.
I deliberately kept --yes to avoid causing breaking changes to users who are adding --yes to the az role assignment delete command and also in case we want to bring #15277 from the dead.
evelyn-ys
previously approved these changes
Dec 26, 2024
jiasli
force-pushed
the
role-assignment-delete
branch
from
2e254e3 to
ff7d0fd
Compare
jiasli
changed the title
az role assignment delete: Stop deleting all role assignments by defaultaz role assignment delete: Stop deleting all role assignments by default
evelyn-ys
approved these changes
Jan 3, 2025
bebound
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az role assignment deleteDescription
Close #13577
az role assignment deleteis an insane footgun. Even though #8862 added a prompt, it is still super dangerous.This PR changes this behavior so that
az role assignment deletedoes nothing if none of--ids,--assignee,--role,--resource-group,--scopeis provided.If you truly want to delete all role assignments, use
A more aggressive solution is to make
--scopea required argument foraz role assignment delete(#30471).Testing Guide