Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Binary Encoding: Adds performance tests with binary encoding enabled. #4943

Conversation

aavasthy
Copy link
Contributor

@aavasthy aavasthy commented Dec 30, 2024

Pull Request Template

Description

Update existing MockedItemBenchmark performance tests for methods CreateItemAsync, CreateItemStreamAsync, ReadItemAsync, ReadItemStreamAsync, UpsertItemAsync, UpsertItemStreamAsync, ReplaceItemAsync, ReplaceItemStreamAsync, DeleteItemAsync, DeleteItemStreamAsync which have binary encoding support. These tests will run in the pipeline and help determine in determining regression when binary encoding feature is enabled.
https://cosmos-db-sdk-public.visualstudio.com/cosmos-db-sdk-public/_build/results?buildId=53508&view=results

image image

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Closing issues

To automatically close an issue: closes #4722

@aavasthy aavasthy self-assigned this Dec 30, 2024
@aavasthy aavasthy added the auto-merge Enables automation to merge PRs label Dec 30, 2024
Copy link
Member

@kundadebdatta kundadebdatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kundadebdatta kundadebdatta added the auto-merge Enables automation to merge PRs label Feb 6, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 536fe06 into master Feb 6, 2025
24 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the users/aavasthy/binary_encoding_update_perf_test branch February 6, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enables automation to merge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binary Encoding - Add/ Extend Performance Tests and Support for End to End Validation
4 participants