Scripts: Adds Stream APIs for CRUD Operations #4978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NaluTripician
requested review from
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
FabianMeiswinkel,
kirillg and
Pilchie
as code owners
| ITrace trace, | ||
| CancellationToken cancellationToken) | ||
| { | ||
| return this.ProcessStreamOperationAsync( |
There was a problem hiding this comment.
IMO layering types over stream might be a better idea
It will help us catch any gaps in stream API's (assuming the typed API's have sufficient coverage), thoughts?
There was a problem hiding this comment.
Currently the ProcessStreamOperationAsync is used in the typed APIs, the only different is there is an intermediary method that does the link uri creation, then calls this method, then converts it into the correct response type. The current Stream API methods create the link then call the ProcessStreamOperationAsync method, skipping the ResponseFactory call.
Microsoft.Azure.Cosmos/src/Resource/Scripts/ScriptsInlineCore.cs
Outdated
Show resolved
Hide resolved
….com/Azure/azure-cosmos-dotnet-v3 into users/nalutripician/ScripsStreamAPIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Adds new Stream APIs for CRUD operations on stored procedures, triggers, and user defined functions in the
Scriptsnamespace.Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #4951