[BULK] - DocuTune remediation - Sensitive terms with GUIDs (part 3) #1021

meganbradley · 2024-10-18T18:57:39Z

Applying sensitive terms with GUID changes as part of Content SFI and outlined in Overview - Writing content securely - Platform Manual. Changes are part of the Microsoft-wide SFI effort. Point of contact: @CelesteDG

DocuTune v1.5.2.0
CorrelationId: ac15aa43-4e2b-437f-ab1c-fdd7e79cd4db

#docutune

meganbradley · 2024-10-18T18:57:41Z

#docutune-review

learn-build-service-prod · 2024-10-18T19:01:36Z

Learn Build status updates of commit 83e4e23:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File	Status	Preview URL	Details
azureadps-2.0/AzureAD/migrate/New-AzureADUser.md	❌Error		Details

azureadps-2.0/AzureAD/migrate/New-AzureADUser.md

Line 28, Column 1: [Error: include-not-found - See documentation] Invalid include link: '~/graphref/api-reference/v1.0/includes/permissions/user-post-users-permissions.md'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

msewaweru · 2024-10-22T09:36:55Z

Trigger rebuild.

learn-build-service-prod · 2024-10-22T09:38:57Z

Learn Build status updates of commit 83e4e23:

✅ Validation status: passed

File	Status	Preview URL
azureadps-2.0-preview/AzureAD/Get-AzureADApplicationProxyApplication.md	✅Succeeded	View (azureadps-2.0-preview)
azureadps-2.0-preview/AzureAD/Get-AzureADApplicationProxyApplicationConnectorGroup.md	✅Succeeded	View (azureadps-2.0-preview)
azureadps-2.0-preview/AzureAD/Get-AzureADApplicationProxyApplicationConnectorGroup.yml	✅Succeeded
azureadps-2.0-preview/AzureAD/Get-AzureADApplicationServiceEndpoint.md	✅Succeeded	View (azureadps-2.0-preview)
azureadps-2.0-preview/AzureAD/Get-AzureADApplicationServiceEndpoint.yml	✅Succeeded
azureadps-2.0-preview/AzureAD/Get-AzureADContactThumbnailPhoto.md	✅Succeeded	View (azureadps-2.0-preview)
azureadps-2.0-preview/AzureAD/Get-AzureADContactThumbnailPhoto.yml	✅Succeeded
azureadps-2.0-preview/AzureAD/Get-AzureADDeletedApplication.md	✅Succeeded	View (azureadps-2.0-preview)
azureadps-2.0-preview/AzureAD/Get-AzureADDeletedApplication.yml	✅Succeeded
azureadps-2.0-preview/AzureAD/Get-AzureADDevice.md	✅Succeeded	View (azureadps-2.0-preview)
azureadps-2.0-preview/AzureAD/Get-AzureADDevice.yml	✅Succeeded
azureadps-2.0-preview/AzureAD/Get-AzureADDeviceConfiguration.md	✅Succeeded	View (azureadps-2.0-preview)
azureadps-2.0-preview/AzureAD/Get-AzureADDeviceConfiguration.yml	✅Succeeded
azureadps-2.0-preview/AzureAD/Get-AzureADDirectoryRole.md	✅Succeeded	View (azureadps-2.0-preview)
azureadps-2.0-preview/AzureAD/Get-AzureADDirectoryRole.yml	✅Succeeded
azureadps-2.0-preview/AzureAD/Get-AzureADDirectoryRoleMember.md	✅Succeeded	View (azureadps-2.0-preview)
azureadps-2.0-preview/AzureAD/Get-AzureADDirectoryRoleMember.yml	✅Succeeded
azureadps-2.0-preview/AzureAD/Get-AzureADGroupMember.md	✅Succeeded	View (azureadps-2.0-preview)
azureadps-2.0-preview/AzureAD/Get-AzureADGroupMember.yml	✅Succeeded
azureadps-2.0-preview/AzureAD/Get-AzureADGroupOwner.md	✅Succeeded	View (azureadps-2.0-preview)

For more details, please refer to the build report.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

msewaweru

Not all real GUIDs have been updated to fake GUIDs.

msewaweru · 2024-10-24T10:04:06Z

azureadps-2.0-preview/AzureAD/Get-AzureADDeletedApplication.md

 421c3f21-22b1-43ea-b438-f00bcad54bd7 f9009add-63a4-4231-9532-9bdc22742922 PowerShellGraphAPI
 4862738f-9ce9-4db6-ab55-e185049f4597 d961ff63-d659-42d5-8ca8-908b3bbb79cb WingTips
 49a8bc01-2751-450b-a2e8-b4267f609513 10d861e6-90b3-4854-a504-f656aab2a14e AzurePopulator
-79592454-dea7-4660-9d91-f1768e5055ac feabcdd1-711a-4d55-ad5e-0d0577aaaa5e analog
+aaaaaaaa-0000-1111-2222-bbbbbbbbbbbb feabcdd1-711a-4d55-ad5e-0d0577aaaa5e analog
 9c4fb233-e88c-4a61-acc9-e8fdcb6758dd e5e29b8a-85d9-41ea-b8d1-2162bd004528 Tenant Schema Extension App
 a5fd58ca-9f1b-4184-ba7c-2595b5831e21 641e422d-29af-49c9-a24e-c0ee05ff10d5 PowerShellRunner
 c4fdf87f-f68e-4859-8bcf-36579b66005e 71715b24-8cdd-432b-a138-86e8ad179274 Woodgrove HR App
 d58d399f-56c3-409c-9efc-fdc28a6bd50e 3ad57eaf-2547-4161-81ae-fde64b5e1c0f ExtensionAttributes


All the GUIDs here need to be updated.

Really? Despite the display names? I would have thought those values need to stay, surely? However, none of them are in the allow list at present and I think tables like this are beyond the current capabilities of DocuTune, mainly because it has the potential of too many false positives. Many of them are too far away from a sensitive term.

That single value is being replaced as a result of L49, and applying it elsewhere.

msewaweru · 2024-10-24T10:04:31Z

azureadps-2.0-preview/AzureAD/Get-AzureADDeletedApplication.yml

    421c3f21-22b1-43ea-b438-f00bcad54bd7 f9009add-63a4-4231-9532-9bdc22742922 PowerShellGraphAPI
    4862738f-9ce9-4db6-ab55-e185049f4597 d961ff63-d659-42d5-8ca8-908b3bbb79cb WingTips
    49a8bc01-2751-450b-a2e8-b4267f609513 10d861e6-90b3-4854-a504-f656aab2a14e AzurePopulator
-    79592454-dea7-4660-9d91-f1768e5055ac feabcdd1-711a-4d55-ad5e-0d0577aaaa5e analog
+    aaaaaaaa-0000-1111-2222-bbbbbbbbbbbb feabcdd1-711a-4d55-ad5e-0d0577aaaa5e analog
    9c4fb233-e88c-4a61-acc9-e8fdcb6758dd e5e29b8a-85d9-41ea-b8d1-2162bd004528 Tenant Schema Extension App
    a5fd58ca-9f1b-4184-ba7c-2595b5831e21 641e422d-29af-49c9-a24e-c0ee05ff10d5 PowerShellRunner
    c4fdf87f-f68e-4859-8bcf-36579b66005e 71715b24-8cdd-432b-a138-86e8ad179274 Woodgrove HR App
    d58d399f-56c3-409c-9efc-fdc28a6bd50e 3ad57eaf-2547-4161-81ae-fde64b5e1c0f ExtensionAttributes
    e9cfe5ad-c9eb-4cd7-87c2-2a69059aeb69 576ea3a9-3d7f-4bcc-a2b5-2d1a5088075e GraphDirectoryExtension


Same issue here.

Gets taken from L35, DocuTune ability stretched for tables.

msewaweru · 2024-10-24T10:09:50Z

azureadps-2.0-preview/AzureAD/Get-AzureADDevice.md

@@ -52,8 +52,8 @@ PS C:\>Get-AzureADDevice

 ObjectId                             DeviceId                             DisplayName
 --------                             --------                             -----------
-3cb87a8f-0a41-4ca8-8910-e56cc00114a3 48445467-033c-42ca-8e38-8d181db1d49c bastias_WindowsPhone_5/1/2016_12:53 PM
-62aae804-8b1a-4ab7-8fda-5068aed1a1f7 3cb87a8f-0a41-4ca8-8910-e56cc00114a3 New Device
+aaaaaaaa-0000-1111-2222-bbbbbbbbbbbb 48445467-033c-42ca-8e38-8d181db1d49c bastias_WindowsPhone_5/1/2016_12:53 PM


Not all ObjectIds have been updated.

msewaweru · 2024-10-24T10:10:31Z

azureadps-2.0-preview/AzureAD/Get-AzureADDevice.yml

-    3cb87a8f-0a41-4ca8-8910-e56cc00114a3 48445467-033c-42ca-8e38-8d181db1d49c bastias_WindowsPhone_5/1/2016_12:53 PM
-    62aae804-8b1a-4ab7-8fda-5068aed1a1f7 3cb87a8f-0a41-4ca8-8910-e56cc00114a3 New Device
+    aaaaaaaa-0000-1111-2222-bbbbbbbbbbbb 48445467-033c-42ca-8e38-8d181db1d49c bastias_WindowsPhone_5/1/2016_12:53 PM
+    62aae804-8b1a-4ab7-8fda-5068aed1a1f7 aaaaaaaa-0000-1111-2222-bbbbbbbbbbbb New Device
    d4fe7726-5966-431c-b3b8-cddc8fdb717d 293872f6-c006-4e6a-8629-07847c5ab078 New Device


Not all ObjectIds have been updated.

These may have to be manual changes based on current capabilities.

msewaweru · 2024-10-24T10:18:01Z

azureadps-2.0-preview/AzureAD/Get-AzureADDirectoryRole.yml

@@ -31,7 +31,7 @@ examples:

    ObjectId                             DisplayName                        Description
    --------                             -----------                        -----------
-    019ea7a2-1613-47c9-81cb-20ba35b1ae48 Company Administrator              Company Administrator role has full access to perform any operation in the company scope.
+    aaaaaaaa-0000-1111-2222-bbbbbbbbbbbb Company Administrator              Company Administrator role has full access to perform any operation in the company scope.


Not all Ids have been updated here.

As above, these look like they should be in an allow list, these have the potential to break things if removed.

msewaweru · 2024-10-24T10:19:26Z

azureadps-2.0-preview/AzureAD/Get-AzureADDirectoryRole.md

@@ -47,7 +47,7 @@ PS C:\>Get-AzureADDirectoryRole

 ObjectId                             DisplayName                        Description
 --------                             -----------                        -----------
-019ea7a2-1613-47c9-81cb-20ba35b1ae48 Company Administrator              Company Administrator role has full access to perform any operation in the company scope.
+aaaaaaaa-0000-1111-2222-bbbbbbbbbbbb Company Administrator              Company Administrator role has full access to perform any operation in the company scope.


Same issue here.

These look like they would be needed, as this is a role. It would break otherwise.

cilwerner · 2024-11-11T13:32:01Z

azureadps-2.0-preview/AzureAD/Get-AzureADDirectoryRoleMember.yml

@@ -16,7 +16,7 @@ syntaxes:
 examples:
 - title: 'Example 1: Get members by role ID'
  code: |-
-    PS C:\>Get-AzureADDirectoryRoleMember -ObjectId "019ea7a2-1613-47c9-81cb-20ba35b1ae48"
+    PS C:\>Get-AzureADDirectoryRoleMember -ObjectId "aaaaaaaa-0000-1111-2222-bbbbbbbbbbbb"


Per the above, if this command is run with scrubbed values, it would probably break.

status

83e4e23

msewaweru closed this Oct 22, 2024

msewaweru reopened this Oct 22, 2024

msewaweru requested changes Oct 24, 2024

View reviewed changes

cilwerner reviewed Nov 11, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BULK] - DocuTune remediation - Sensitive terms with GUIDs (part 3) #1021

[BULK] - DocuTune remediation - Sensitive terms with GUIDs (part 3) #1021

meganbradley commented Oct 18, 2024

meganbradley commented Oct 18, 2024

learn-build-service-prod bot commented Oct 18, 2024

msewaweru commented Oct 22, 2024

learn-build-service-prod bot commented Oct 22, 2024

msewaweru left a comment

msewaweru Oct 24, 2024

cilwerner Nov 11, 2024

msewaweru Oct 24, 2024

cilwerner Nov 11, 2024

msewaweru Oct 24, 2024

msewaweru Oct 24, 2024

cilwerner Nov 11, 2024

msewaweru Oct 24, 2024

cilwerner Nov 11, 2024

msewaweru Oct 24, 2024

cilwerner Nov 11, 2024

cilwerner Nov 11, 2024

[BULK] - DocuTune remediation - Sensitive terms with GUIDs (part 3) #1021

Are you sure you want to change the base?

[BULK] - DocuTune remediation - Sensitive terms with GUIDs (part 3) #1021

Conversation

meganbradley commented Oct 18, 2024

meganbradley commented Oct 18, 2024

learn-build-service-prod bot commented Oct 18, 2024

❌ Validation status: errors

msewaweru commented Oct 22, 2024

learn-build-service-prod bot commented Oct 22, 2024

✅ Validation status: passed

msewaweru left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment