Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for 0.8.9 (uamqp focus) #136

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Changes for 0.8.9 (uamqp focus) #136

merged 1 commit into from
Jan 28, 2020

Conversation

digimaun
Copy link
Member

  • Increments version of uamqp to the one validated by CI
  • Improves error feedback (actually showing what went wrong in stdout versus having to use --debug) from the out-of-band uamqp installation.
  • CI improvements: Sets PYTHONPATH to the output of CLI core get_extension_path, increment MacOS image version, ensures junit_family setting of xunit1
  • Misc test improvements
  • Refactor unnecessary .get()'s from login validator

Note: There are some unrelated issues with pnp life cycle operations preventing complete test pass.


This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact [email protected] with any additional questions or comments.

Thank you for contributing to the IoT extension!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • If introducing new functionality or modified behavior, are they backed by unit and integration tests?
  • In the same context as above are command names and their parameter definitions accurate? Do help docs have sufficient content?
  • Have all unit and integration tests passed locally? i.e. pytest -s <project root>/azext_iot/tests
  • Have static checks passed using the .pylintrc and .flake8 rules? Look at the CI scripts for example usage.

@digimaun digimaun merged commit 72acc2d into Azure:dev Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants