-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] Adds nested Edge hierarchy creation command #580
Conversation
Added help and examples for edge hierarchy commands Modified inline device args to parse 'id' instead of 'device_id' for brevity, updated tests
@@ -309,3 +309,32 @@ def load_iothub_help(): | |||
type: command | |||
short-summary: Upload a local file as a device to a pre-configured blob storage container. | |||
""" | |||
|
|||
helps["iot edge hierarchy"] = """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should double-check the official terminology for this topic to ensure alignment...I've seen both "hierarchy" and "topology" being used.
elif devices: | ||
# Process --device arguments | ||
config = NestedEdgeConfig( | ||
version="1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should ensure the "1.0" Nested Edge Config is documented somewhere.
|
||
|
||
@pytest.mark.usefixtures("set_cwd") | ||
class TestNestedEdgeHierarchy(IoTLiveScenarioTest): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not strictly necessary for this PR, but at some point we need to converge on the new fixtures oriented test pattern for integration tests (as introduced in ADU CLI, and applied in this in-flight PR #582)
Moved to feature branch / PR #591 |
Raising this PR in draft mode to get initial feedback while we discuss future enhancements.
az iot edge hierarchy create
experimental command that:--device
arguments or with a YAML/JSON config fileNew dependency:
treelib
- used as a helper for validating device hierarchies and visualization.Unfinished tasks:
This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact [email protected] with any additional questions or comments.
Thank you for contributing to the IoT extension!
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Intent for Production
dev
ormain
are of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.Basic expectations
pytest <project root> -vv
. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set..pylintrc
and.flake8
rules? Look at the CI scripts for example usage.Azure IoT CLI maintainers reserve the right to enforce any of the outlined expectations.
A PR is considered ready for review when all basic expectations have been met (or do not apply).