Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add narg kvp to configuration/deployment create and create inline json wiki page #610

Merged
merged 10 commits into from
Jan 18, 2023

Conversation

Elsie4ever
Copy link
Contributor

@Elsie4ever Elsie4ever commented Jan 6, 2023

Addition of new parameters is introduced in az iot hub configuration create and
az iot edge deployment create to let user insert labels and metrics in key-value pair style
And also created the inline json wiki page https://github.com/Azure/azure-iot-cli-extension/wiki/Inline-JSON-help

This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact [email protected] with any additional questions or comments.

Thank you for contributing to the IoT extension!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

Intent for Production

  • It is expected that pull requests made to default or core branches such as dev or main are of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.

Basic expectations

  • If introducing new functionality or modified behavior, are they backed by unit and/or integration tests?
  • In the same context as above are command names and their parameter definitions accurate? Do help docs have sufficient content?
  • Have all the relevant unit and integration tests pass? i.e. pytest <project root> -vv. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set.
  • Have linter checks passed using the .pylintrc and .flake8 rules? Look at the CI scripts for example usage.
  • Have extraneous print or debug statements, commented out code-blocks or code-statements (if any) been removed from the surface area of changes?
  • Have you made an entry in HISTORY.rst which concisely explains your user-facing feature or change?

Azure IoT CLI maintainers reserve the right to enforce any of the outlined expectations.

A PR is considered ready for review when all basic expectations have been met (or do not apply).

@Elsie4ever Elsie4ever requested a review from digimaun as a code owner January 6, 2023 19:56
@Elsie4ever Elsie4ever requested review from c-ryan-k and vilit1 January 6, 2023 19:59
@Elsie4ever
Copy link
Contributor Author

related integration test passed
image

@Elsie4ever
Copy link
Contributor Author

related unit test passed
image

azext_iot/_params.py Outdated Show resolved Hide resolved
azext_iot/_params.py Outdated Show resolved Hide resolved
azext_iot/_params.py Outdated Show resolved Hide resolved
azext_iot/_help.py Outdated Show resolved Hide resolved
@digimaun
Copy link
Member

digimaun commented Jan 6, 2023

related unit test passed

Thank you, unit tests run in the PR pipeline so you don't need to include those specifically

azext_iot/_params.py Outdated Show resolved Hide resolved
azext_iot/_params.py Outdated Show resolved Hide resolved
azext_iot/_params.py Outdated Show resolved Hide resolved
HISTORY.rst Show resolved Hide resolved
azext_iot/_help.py Outdated Show resolved Hide resolved
azext_iot/_params.py Outdated Show resolved Hide resolved
azext_iot/_params.py Outdated Show resolved Hide resolved
azext_iot/_help.py Outdated Show resolved Hide resolved
Copy link
Member

@c-ryan-k c-ryan-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits around wording and how we present the help / params - otherwise looks good to me

azext_iot/_params.py Outdated Show resolved Hide resolved
azext_iot/_params.py Outdated Show resolved Hide resolved
azext_iot/deviceupdate/_help.py Outdated Show resolved Hide resolved
@Elsie4ever Elsie4ever merged commit f58d37a into Azure:dev Jan 18, 2023
@Elsie4ever
Copy link
Contributor Author

pipline build link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants