-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add narg kvp to configuration/deployment create and create inline json wiki page #610
Merged
Elsie4ever
merged 10 commits into
Azure:dev
from
Elsie4ever:user/jiacju/updateConfigargs
Jan 18, 2023
Merged
Add narg kvp to configuration/deployment create and create inline json wiki page #610
Elsie4ever
merged 10 commits into
Azure:dev
from
Elsie4ever:user/jiacju/updateConfigargs
Jan 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digimaun
reviewed
Jan 6, 2023
digimaun
reviewed
Jan 6, 2023
digimaun
reviewed
Jan 6, 2023
digimaun
reviewed
Jan 6, 2023
digimaun
reviewed
Jan 6, 2023
Thank you, unit tests run in the PR pipeline so you don't need to include those specifically |
digimaun
reviewed
Jan 9, 2023
digimaun
reviewed
Jan 9, 2023
digimaun
reviewed
Jan 9, 2023
digimaun
reviewed
Jan 9, 2023
digimaun
reviewed
Jan 9, 2023
digimaun
reviewed
Jan 9, 2023
digimaun
reviewed
Jan 9, 2023
digimaun
reviewed
Jan 9, 2023
digimaun
reviewed
Jan 9, 2023
vilit1
reviewed
Jan 10, 2023
vilit1
reviewed
Jan 10, 2023
digimaun
reviewed
Jan 10, 2023
digimaun
reviewed
Jan 17, 2023
c-ryan-k
reviewed
Jan 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nits around wording and how we present the help / params - otherwise looks good to me
digimaun
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of new parameters is introduced in az iot hub configuration create and
az iot edge deployment create to let user insert labels and metrics in key-value pair style
And also created the inline json wiki page https://github.com/Azure/azure-iot-cli-extension/wiki/Inline-JSON-help
This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact [email protected] with any additional questions or comments.
Thank you for contributing to the IoT extension!
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Intent for Production
dev
ormain
are of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.Basic expectations
pytest <project root> -vv
. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set..pylintrc
and.flake8
rules? Look at the CI scripts for example usage.Azure IoT CLI maintainers reserve the right to enforce any of the outlined expectations.
A PR is considered ready for review when all basic expectations have been met (or do not apply).