-
Notifications
You must be signed in to change notification settings - Fork 42
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix: V1 Frames have DateTypes not recognized
V1 frames, while containing a ColumnType, often do not fill them in. The code muust rely on DateType, which details what the C# type would be. This issue exposed the following problems: - Did not include the correct type for a bool, which was "boolean". Possibly other types. - Did not notice because Mgmt() was not used for anything but sending commands in our integraiton tests and code base Fixes: - Updated our internal integration test for the regression - Added a new translation map that includes all values and aliases that Kusto docs says is supported. - Made a slight tweak to a test, but did not add a new non-integration test, it would only be testing the existing table which isn't useful.
- Loading branch information
John Doak
authored and
John Doak
committed
Mar 16, 2020
1 parent
a17cdfa
commit 3d32447
Showing
5 changed files
with
48 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters