-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ClientCore] Introduce Union type #43778
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdk/clientcore/core/src/main/java/io/clientcore/core/util/union/ParameterizedTypeImpl.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/util/union/ParameterizedTypeImpl.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/util/union/Union.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/util/union/Union.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/util/union/Union.java
Outdated
Show resolved
Hide resolved
srnagar
reviewed
Jan 13, 2025
sdk/clientcore/core/src/main/java/io/clientcore/core/util/union/ParameterizedTypeImpl.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/util/union/Union.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/util/union/UnionTypes.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/util/union/Union.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/util/union/Union.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/util/union/Union.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/util/ParameterizedTypeImpl.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/util/ParameterizedTypeImpl.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/util/ParameterizedTypeImpl.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/util/Union.java
Outdated
Show resolved
Hide resolved
API change check APIView has identified API level changes in this PR and created following API reviews. |
srnagar
reviewed
Jan 23, 2025
sdk/clientcore/core/src/main/java/io/clientcore/core/util/Union.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/util/Union.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/util/Union.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/samples/java/io/clientcore/core/util/union/BasicUnion.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/samples/java/io/clientcore/core/util/union/GenericModelType.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/util/Union.java
Outdated
Show resolved
Hide resolved
srnagar
approved these changes
Jan 28, 2025
sdk/clientcore/core/src/main/java/io/clientcore/core/util/Union.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/samples/java/io/clientcore/core/util/union/GenericModelType.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/samples/java/io/clientcore/core/util/union/GenericModelType.java
Outdated
Show resolved
Hide resolved
srnagar
reviewed
Jan 28, 2025
sdk/clientcore/core/src/main/java/io/clientcore/core/util/Union.java
Outdated
Show resolved
Hide resolved
alzimmermsft
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the idea of Union type to the client core:
A Union type could be one of the mixed types. For example,
1, Create an instance of mixed types, Integer, Double, and String, you can use the following code
2, Set the value
3, How to consume the value:
3.1, In Java 17+, use the
switch
:or use
if-else
:3.2, use the
tryConsume
lambda method: