-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitor OpenTelemetry][Monitor OpenTelemetry Exporter] Add Operation Name Propagation for Dependencies and Logs #31778
Merged
JacksonWeber
merged 16 commits into
Azure:main
from
JacksonWeber:jacksonweber/add-operation-name
Dec 2, 2024
Merged
[Monitor OpenTelemetry][Monitor OpenTelemetry Exporter] Add Operation Name Propagation for Dependencies and Logs #31778
JacksonWeber
merged 16 commits into
Azure:main
from
JacksonWeber:jacksonweber/add-operation-name
Dec 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API change check API changes are not detected in this pull request. |
hectorhdzg
reviewed
Nov 25, 2024
sdk/monitor/monitor-opentelemetry-exporter/src/utils/logUtils.ts
Outdated
Show resolved
Hide resolved
hectorhdzg
reviewed
Nov 25, 2024
hectorhdzg
reviewed
Nov 25, 2024
sdk/monitor/monitor-opentelemetry/src/logs/logRecordProcessor.ts
Outdated
Show resolved
Hide resolved
harsimar
reviewed
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should double check what the property name for the operation name is before merging
hectorhdzg
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/monitor-opentelemetry
@azure/monitor-opentelemetry-exporter
Describe the problem that is addressed by this PR
We should support operation name propagation for dependencies and logs. The operation name is sourced from the parent request span and propagates to any child dependencies or logs.
Are there test cases added in this PR? (If not, why?)
Yes
Checklists