Adding upload file and poll operation with sample and test #31928
+81
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZachhK
changed the title
ganeshyb
reviewed
Nov 25, 2024
ganeshyb
reviewed
Nov 25, 2024
| await new Promise(resolve => setTimeout(resolve, sleepInterval)); | ||
| const updatedResult = await context.path(`/files/${result.body.id}`, result.body.id).get(options); | ||
| result.body = updatedResult.body; | ||
| } |
There was a problem hiding this comment.
Provide a way to stop polling.
jeremymeng
reviewed
Nov 25, 2024
| @@ -31,6 +31,19 @@ export async function uploadFile( | |||
| return result.body; | |||
| } | |||
|
|
|||
| /** Uploads a file for use by other operations. */ | |||
| export async function uploadFileAndPoll( | |||
There was a problem hiding this comment.
@ganeshyb would we want to use an LRO here?
There was a problem hiding this comment.
I am not sure actually, could you help me understand what the traffic will look like?
We leverage the first request to upload the file successfully but when this request is back this doesn't mean the server side is completed. So we have following requests to poll status? Will this be the traffic?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.