fix(playwrighttesting): Add support for multiple global files #31932
+211
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sid200026
requested review from
bterlson,
a team,
puagarwa and
ShreyaAnand
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
kashish2508
approved these changes
Nov 26, 2024
puagarwa
approved these changes
Nov 26, 2024
maorleger
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/microsoft-playwright-testing
Issues associated with this PR
Fixes microsoft/playwright-testing-service#151
Describe the problem that is addressed by this PR
Playwright OSS had introduced support for multiple global setup/teardown files via microsoft/playwright#32955. This SDK did not support array of string as input params and hence threw a TypeError.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Yes
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists