[mgmt] draft pr for modular migrate #32682
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Mgmt
mpodwysocki
reviewed
Jan 23, 2025
| "@types/mocha": "^10.0.0", | ||
| "@azure/eslint-plugin-azure-sdk": "^3.0.0", | ||
| "@azure/identity": "^4.6.0", | ||
| "@microsoft/api-extractor": "^7.40.3", |
There was a problem hiding this comment.
API Extractor should not be necessary to add.
mpodwysocki
reviewed
Jan 23, 2025
| "extract-api": "dev-tool run extract-api", | ||
| "format": "echo skipped", | ||
| "execute:samples": "dev-tool samples run samples-dev", | ||
| "extract-api": "dev-tool run vendored rimraf review && dev-tool run vendored mkdirp ./review && dev-tool run extract-api", |
There was a problem hiding this comment.
No calls to mkdirp should be required anymore as extract-api now has it built-in
mpodwysocki
reviewed
Jan 23, 2025
| } | ||
|
|
||
| async function main(): Promise<void> { | ||
| getAssociation(); |
There was a problem hiding this comment.
This should be awaited otherwise it does not catch any errors and will silently fail should an exception be thrown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists