Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Add new attribute to resent HTTP request spans #35069

Merged
merged 1 commit into from
May 21, 2024

Conversation

pvaneck
Copy link
Member

@pvaneck pvaneck commented Apr 4, 2024

DistributedTracingPolicy will now set an attribute, http.request.resend_count, on HTTP spans for resent requests to indicate the resend attempt count.

Part of: #32803

@pvaneck pvaneck force-pushed the core-retry-tracing branch 2 times, most recently from ae48c47 to 4060902 Compare April 4, 2024 01:43
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@pvaneck pvaneck force-pushed the core-retry-tracing branch 2 times, most recently from 6a0a4c6 to 65477c6 Compare April 4, 2024 22:35
@pvaneck pvaneck marked this pull request as ready for review April 9, 2024 02:06
@pvaneck pvaneck requested a review from lmolkova April 9, 2024 02:06
Copy link
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

`DistributedTracingPolicy` will now set an attribute, `http.request.resend_count`,
on HTTP spans for resent requests to indicate the resend attempt count.

Signed-off-by: Paul Van Eck <[email protected]>
@pvaneck pvaneck force-pushed the core-retry-tracing branch from 65477c6 to 556dc2e Compare May 20, 2024 21:46
@pvaneck
Copy link
Member Author

pvaneck commented May 21, 2024

/check-enforcer override

@pvaneck pvaneck merged commit 406d463 into Azure:main May 21, 2024
208 of 224 checks passed
@pvaneck pvaneck deleted the core-retry-tracing branch May 21, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants