[Storage] Improve Storage test utilities and refactor navigation methods #2525
+74
−137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
vincenttran-msft
changed the title
vincenttran-msft
requested review from
heaths,
RickWinter,
LarryOsterman and
jalauzon-msft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR improves test utilities and refactors navigation methods for Azure Storage by updating helper functions and client constructions to better support asynchronous container creation and pipeline persistence.
- Adds new utility functions (get_blob_name and get_container_name) to generate consistent names.
- Refactors get_container_client into an async function with an optional flag to create the container.
- Updates tests and client constructors in BlobServiceClient, BlobContainerClient, and BlobClient to align with these changes.
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/storage/azure_storage_blob_test/src/lib.rs | Added get_blob_name and get_container_name; refactored get_container_client to support async container creation and removed the legacy get_blob_client. |
| sdk/storage/azure_storage_blob/tests/blob_container_client.rs | Updated usage of get_container_client to use the async API with an explicit creation flag. |
| sdk/storage/azure_storage_blob/tests/blob_client.rs | Adjusted blob client retrieval by using container_client.blob_client with the new naming utilities and async container creation. |
| sdk/storage/azure_storage_blob/src/clients/blob_service_client.rs | Refactored to expose internal fields and update blob_container_client construction for improved pipeline persistence. |
| sdk/storage/azure_storage_blob/src/clients/blob_container_client.rs | Refactored to expose internal fields and update blob_client creation via a generated client instance. |
| sdk/storage/azure_storage_blob/src/clients/blob_client.rs | Refactored to expose internal fields representing the endpoint and client. |
Files not reviewed (1)
- sdk/storage/assets.json: Language not supported
Comments suppressed due to low confidence (1)
sdk/storage/azure_storage_blob_test/src/lib.rs:66
- [nitpick] The function documentation could be enhanced to clearly explain the behavior of the 'create' flag, including its asynchronous container creation and any error propagation.
pub async fn get_container_client(
heaths
approved these changes
Apr 28, 2025
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
sdk/storage/azure_storage_blob/src/clients/blob_container_client.rs
Outdated
Show resolved
Hide resolved
jalauzon-msft
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following: