Fix streaming upload #670
Open
Fix streaming upload #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Source stream may return less data than what was requested and in case size of the entire blob was not known this was not taken into account when reading more data, sometimes resulting in all data being read from the stream and sent in one chunk, which could end up being larger than the maximum supported size.
_BlobChunkUploader called tell() on the source stream even though it did not use the result for anything. If the stream was non-seekable this just made the operation fail completely unnecessarily.
Codecov Report
@@ Coverage Diff @@
## master #670 +/- ##
=======================================
Coverage 86.98% 86.99%
=======================================
Files 52 52
Lines 5288 5289 +1
Branches 566 567 +1
=======================================
+ Hits 4600 4601 +1
Misses 515 515
Partials 173 173
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uploading blob that was read from source like pipe was not working correctly due to couple of bugs.