Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pyamqp] pylint/mypy/black #314

Open
wants to merge 3 commits into
base: pyproto
Choose a base branch
from

Conversation

yunhaoling
Copy link
Contributor

@yunhaoling yunhaoling commented Mar 15, 2022

Copy link
Member

@swathipil swathipil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments but o/w lgtm!

Any,
Union,
Optional,
) # pylint: disable=unused-import
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intentional disable unused-import or is this leftover from before?


def encode_float(
output, value, with_constructor=True, **kwargs
): # pylint: disable=unused-argument
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming all the unused-arguments are because of TODOs and they'll be used in the future?

offset = frame_header[4]
frame_type = frame_header[5]
# frame_type = frame_header[5]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a TODO/commented for now or should it be deleted?

offset = frame_header[4]
frame_type = frame_header[5]
# frame_type = frame_header[5]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO?

return (int(utc_now().timestamp()) - token_put_time) >= auth_timeout
else:
return False
return 0 < auth_timeout <= (int(utc_now().timestamp()) - token_put_time)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮 Is this Python 3 syntax? Was this always available?

@yunhaoling yunhaoling changed the title [pyproto] pylint/mypy/black [pyamqp] pylint/mypy/black Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants