-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding quickstart for validate with a Linux image #36
base: main
Are you sure you want to change the base?
Conversation
"customize": [ | ||
{ | ||
"type": "Shell", | ||
"name": "AddBuildArtifacts3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: What is the significance of 3 here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix indentation.
Please check everywhere in this file.
@@ -0,0 +1,57 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the filename consistent with existing naming scheme.
If current scheme doesn't seem okay to you then please change the scheme for all of them - but the customer should have a consistent experience.
@@ -0,0 +1,57 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please share details on how this has been tested?
For example, a customer would likely copy-paste this text; look for everything in angle brackets "<>" and replace with custom values. At that point the template should just work.
Has such a run been done on this quickstart example?
"sudo touch /buildArtifacts3/imageBuilder.md" | ||
] | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary blank line
No description provided.