-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding firewallIP to output of module #3879
Open
hundredacres
wants to merge
6
commits into
Azure:main
Choose a base branch
from
hundredacres:feat/issues/3875
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avm-team-linter
bot
added
the
Needs: Core Team 🧞
This item needs the AVM Core Team to review it
label
Dec 4, 2024
microsoft-github-policy-service
bot
added
Needs: Triage 🔍
Maintainers need to triage still
Type: AVM 🅰️ ✌️ Ⓜ️
This is an AVM related issue
labels
Dec 4, 2024
eriqua
reviewed
Dec 7, 2024
@@ -263,6 +263,7 @@ output hubAzureFirewalls object[] = [ | |||
location: hubAzureFirewall[index].outputs.location | |||
name: hubAzureFirewall[index].outputs.name | |||
resourceId: hubAzureFirewall[index].outputs.resourceId | |||
privateIp: hubAzureFirewall[index].outputs.privateIp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update minor version in version.json. Although small and backward compatible, this qualifies as a change to the API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
eriqua
added
Class: Pattern Module 📦
This is a pattern module
and removed
Needs: Triage 🔍
Maintainers need to triage still
labels
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Class: Pattern Module 📦
This is a pattern module
Needs: Core Team 🧞
This item needs the AVM Core Team to review it
Type: AVM 🅰️ ✌️ Ⓜ️
This is an AVM related issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding firewallIP to outout of module.
Fixes #3875
Closes #3875
Pipeline Reference
Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.