Hot Chocolate 14 Migration #2348
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelstaib
commented
Aug 23, 2024
| @@ -4,6 +4,7 @@ | |||
| using System.Diagnostics.CodeAnalysis; | |||
| using System.Security.Claims; | |||
| using HotChocolate.AspNetCore.Authorization; | |||
| using HotChocolate.Authorization; | |||
There was a problem hiding this comment.
With Hot Chocolate we have abstracted the authorization hooks to allow users to more easily bring in new. providers without the need to rely on ASP.NET core APIs
michaelstaib
commented
Aug 23, 2024
| @@ -137,7 +137,7 @@ public async ValueTask ExecuteMutateAsync(IMiddlewareContext context) | |||
| /// <returns> | |||
| /// Returns the runtime field value. | |||
| /// </returns> | |||
| public static object? ExecuteLeafField(IPureResolverContext context) | |||
| public static object? ExecuteLeafField(IResolverContext context) | |||
There was a problem hiding this comment.
The pure resolver context and the resolver context are now aligned.
michaelstaib
commented
Aug 23, 2024
| @@ -13,7 +12,7 @@ namespace Azure.DataApiBuilder.Service.GraphQLBuilder.CustomScalars | |||
| /// </summary> | |||
| public class SingleType : FloatTypeBase<float> | |||
| { | |||
| public static readonly NameString TypeName = new("Single"); | |||
There was a problem hiding this comment.
We removed NameString in Hot Chocolate 13 as this semantic string object just caused a lot of allocation.
michaelstaib
commented
Aug 23, 2024
| ArgumentNode? arg = directiveNode?.Arguments.First(a => a.Name.Value == "target"); | ||
|
|
||
| return (string?)arg?.Value.Value; | ||
| Directive? directive = (Directive?)infield.Directives.FirstOrDefault(DirectiveName); |
There was a problem hiding this comment.
The directive collection has now optimized lookup methods. which reduces the code needed to get things from type system members.
michaelstaib
commented
Aug 23, 2024
| @@ -197,263 +196,260 @@ public static bool CreateAuthorizationDirectiveIfNecessary( | |||
| /// <returns>True when name resolution succeeded, false otherwise.</returns> | |||
| public static bool TryExtractGraphQLFieldModelName(IDirectiveCollection fieldDirectives, [NotNullWhen(true)] out string? modelName) | |||
| { | |||
| foreach (Directive dir in fieldDirectives) | |||
| foreach (Directive dir in fieldDirectives[ModelDirectiveType.DirectiveName]) | |||
There was a problem hiding this comment.
The original code here looked wrong ... lets chat about the intention here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
With Hot Chocolate 14 we have invested a lot into security, performance and GraphQL protocol standards.
What is this change?
This PR will modernize the GraphQL stack of dab.
How was this tested?