-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create Entra identities with Bicep #298
base: main
Are you sure you want to change the base?
Conversation
Hey @picccard, while I love that we're able to move some of the Identity items to Bicep now, I'm hesitant to break this into multiple deployment scripts. I'd prefer a single, easy to use script for the majority of users whom just want the "easy button" deployment. We can also have some more advanced options for power users where they can have other options (like you've provided) of more granular deployment scripts, purely Bicep, or even perhaps Terraform. I hope that makes sense, but the net/net is we should keep the single "easy" deployment script and add additional options for Power Users whom perhaps want to add these steps into pipelines or other CI/CD processes within their own environment. Please let me know your thoughts or perhaps if I've misinterpreted your changes proposed here, and thank you for the wonderful contributions as always! |
Intro
Looking to do more with bicep and have less in the
deploy.ps1
. Would like to have ARM handle most of the input validation.Bicep templates for Microsoft Graph resources is still in public preview
Bicep deployments
The Entra Id app registrations and Azure infrastructure is bundled into seperate
main.bicep
files.deploy/identity/main.bicep
deploy/main.bicep
(move infra.bicep to its own subfolder?)Configuration
All configuration should be done in
.bicepparam
-files.Challenges
The Entra Id app registration deployment has circular dependencies (both depend on values from the other for a complete setup):
The redirectUri for the UI app might not be known until after the infrastructure is deployed.
Solution
The Entra Id app registration deployment is done twice.
uiAppId
&engineAppId
, and a placeholder value foruiAppRedirectUris
.uiAppId
&engineAppId
, anduiAppRedirectUris
can be change at any point.Flexible deployment options
The
identity/main.bicep
&infra/main.bicep
can be deployed with:Example setup
uiAppId
&engineAppId
, and a placeholder value foruiAppRedirectUris
.uiAppId
,engineAppId
,uiAppRedirectUris
.The
deploy
directory includes the following example scripts:deploy-identity.ps1
,deploy-infrastructure.ps1
anddeploy-all.ps1
.