Update rust compiler to 1.84 version (#124)

Fix clippy warnings from new version.

.github/workflows/build.yaml

@@ -21,7 +21,7 @@ jobs:
     - name: Install rust stable
       uses: dtolnay/rust-toolchain@stable
       with:
-        toolchain: 1.79.0
+        toolchain: 1.84.0
         components: rustfmt, clippy
 
     - name: Run cargo check
@@ -97,7 +97,7 @@ jobs:
     - name: Install rust stable
       uses: dtolnay/rust-toolchain@stable
       with:
-        toolchain: 1.79.0
+        toolchain: 1.84.0
         components: rustfmt, clippy
 
     - name: Run cargo check

crates/libs/core/src/lib.rs

@@ -7,8 +7,8 @@
 //! For most scenarios, you'll want the features. However, in some scenarios, such as:
 //! - integrating Rust into an existing Service Fabric Application written in another language
 //! - when you are using the lower-level COM API to do something more custom
-//! You might not need all of the functionality that the mssf-core crate provides
-//! In this case, you can configure only what you need to reduce dependencies and compile times.
+//!     You might not need all of the functionality that the mssf-core crate provides
+//!     In this case, you can configure only what you need to reduce dependencies and compile times.
 //!
 //! * ** config_source **  -
 //!     Provides an implementation of config::Source. Requires config_rs crate

crates/libs/core/src/runtime/stateful_proxy.rs

@@ -373,12 +373,12 @@ impl StatefulServicePartition {
         unsafe { self.com_impl.ReportMoveCost(move_cost.into()) }
     }
 
-    /// Remarks:
-    /// The health information describes the report details, like the source ID, the property,
-    /// the health state and other relevant details. The partition uses an internal health client
-    /// to send the reports to the health store. The client optimizes messages to Health Manager
-    /// by batching reports per a configured duration (Default: 30 seconds). If the report has high priority,
-    /// you can specify send options to send it immediately.
+    // Remarks:
+    // The health information describes the report details, like the source ID, the property,
+    // the health state and other relevant details. The partition uses an internal health client
+    // to send the reports to the health store. The client optimizes messages to Health Manager
+    // by batching reports per a configured duration (Default: 30 seconds). If the report has high priority,
+    // you can specify send options to send it immediately.
 
     /// Reports current partition health.
     pub fn report_partition_health(&self, healthinfo: &HealthInformation) -> crate::Result<()> {

crates/libs/core/src/sync/bridge_context.rs

@@ -103,7 +103,8 @@ where
     /// This api is in some sense unsafe, because the developer needs to ensure
     /// the following:
     /// * context impl type is `BridgeContext3`, and the T matches the SF end api
-    /// return type.
+    ///   return type.
+    ///
     /// Note that if T is of Result<ICOM> type, the current function return type is
     /// Result<Result<ICOM>>, so unwrap is needed.
     pub fn result(context: windows_core::Ref<IFabricAsyncOperationContext>) -> crate::Result<T> {

crates/libs/core/src/types/common/metrics.rs

@@ -42,7 +42,7 @@ pub struct LoadMetricListRef<'a> {
     owner: PhantomData<&'a [LoadMetric]>,
 }
 
-impl<'a> LoadMetricListRef<'a> {
+impl LoadMetricListRef<'_> {
     pub fn from_slice(v: &[LoadMetric]) -> Self {
         let metrics = v.iter().map(FABRIC_LOAD_METRIC::from).collect::<Vec<_>>();
         Self {

rust-toolchain.toml

@@ -2,5 +2,5 @@
 # cargo + rustup will use this to consistently build the project
 # with the same version across all checkouts and environments
 [toolchain]
-channel = "1.79.0"
+channel = "1.84.0"
 profile = "default"