Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove outputting entire resource object #158

Merged
merged 2 commits into from
Jan 30, 2025
Merged

remove outputting entire resource object #158

merged 2 commits into from
Jan 30, 2025

Conversation

nellyk
Copy link
Member

@nellyk nellyk commented Jan 17, 2025

Description

Closes #148

Type of Change

  • Non-module change (e.g. CI/CD, documentation, etc.)
  • [x ] Azure Verified Module updates:
    • [ x] Bugfix containing backwards compatible bug fixes
      • [ x] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates.
    • Breaking changes.
    • Update to documentation

Checklist

  • [ x] I'm sure there are no other open Pull Requests for the same update/change
  • [ x] My corresponding pipelines / checks run clean and green without any errors or warnings
  • [ x] I did run all pre-commit checks

@kewalaka
Copy link

the removal is correct, but the spec says computed outputs should be present. I've done an example in #161

@zioproto
Copy link
Collaborator

@kewalaka I added most of the outputs now. Could you please review ?

could you please also review this provider doc patch here: hashicorp/terraform-provider-azurerm#28605
I think I found the docs were not exactly right when working on this PR.

thanks

@nellyk nellyk merged commit 256c0a7 into main Jan 30, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Maintainers need to triage still
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: outputs need re-alignment to AVM spec
3 participants