Make network policy configurable #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
Needs: Triage 🔍
1 task
zioproto
commented
Feb 5, 2025
| @@ -121,9 +121,9 @@ resource "azurerm_kubernetes_cluster" "this" { | |||
| network_profile { | |||
| network_plugin = "azure" | |||
| load_balancer_sku = "standard" | |||
| network_data_plane = "cilium" | |||
| network_data_plane = var.network_policy == "cilium" ? "cilium" : null | |||
There was a problem hiding this comment.
@nellyk is there a more elegant way to write this condition ? I am not sure I have done this in the best way
There was a problem hiding this comment.
This is how we have done it on our private module
There was a problem hiding this comment.
It's the same way as I did in #161 - except I also included the azure CNI.
I can understand not including this to guide people towards calico or cilium, makes sense without affecting support for recommended practices.
Just noting I'm waiting feedback from either @nellyk or @zioproto on whether the general direction of #161 is of interest & it is worth splitting it out?
nellyk
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make network policy configurable, using either cilium or calico.
Fixes #165
Closes #165