Add unique_string function #653
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magodo
reviewed
Nov 13, 2024
| return murmurHash64A(bytes, 0) | ||
| } | ||
|
|
||
| func murmurHash64A(data []byte, seed uint32) uint64 { |
There was a problem hiding this comment.
Can we add unit tests for this function as https://github.com/smokedlinq/powershell-az/blob/d5461aa62614ee741275b18ba7f710fb3e6b0856/powershell-az.tests.ps1?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ARM function
uniqueStringso that the community can migrate from existing ARM/BICEP based deployments that utilize the function to create resources.The golang version was converted from a C#/PowerShell utility I wrote a few years ago.
The values can be verified with a simple bicep configuration such as:
P.S. Without a spreadable tfsdk type for a list of strings, an array seemed to be the most appropriate approach as the parameter.