Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing freezing dockerfile create page #945

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

ReinierCC
Copy link
Collaborator

This PR is to fix the following issue:

Screenshot 2024-09-24 at 11 15 44 AM

where the "Automated Deployments: Draft a Dockerfile" page would freeze for any user input after clicking the create button.

This occured because the draft command being executed to create the dockerfile was waiting for cli style user input about the BUILDVERSION.

Screenshot 2024-09-24 at 11 17 50 AM

Previously the builderImageTag was or'ed with an empty string. But builderImageTag was already of type string | null .
Screenshot 2024-09-24 at 11 19 46 AM

Screenshot 2024-09-24 at 11 21 28 AM

By removing the empty string, the draft binary uses BUILDERTAG as null and does not request user input.

There still exists issue #944 for python dockerfiles. But the fix for that would best come from a modification to the draft binary itself.

@ReinierCC
Copy link
Collaborator Author

VSIX For Testing (Remove .zip from file name):

vscode-aks-tools-1.4.9-docker-create-freeze-fix.vsix.zip

@Tatsinnit Tatsinnit added bug Something isn't working enhancement 🚀 New feature or request or improvements on existing code. labels Sep 24, 2024
Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this, looks good to me. I will FYI this in our internal channel just as information. 🙏 ❤️

@Tatsinnit Tatsinnit merged commit 0c430f2 into Azure:main Sep 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement 🚀 New feature or request or improvements on existing code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants