Fixing freezing dockerfile create page #945
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix the following issue:
where the "Automated Deployments: Draft a Dockerfile" page would freeze for any user input after clicking the create button.
This occured because the draft command being executed to create the dockerfile was waiting for cli style user input about the BUILDVERSION.
Previously the builderImageTag was or'ed with an empty string. But builderImageTag was already of type string | null .
By removing the empty string, the draft binary uses BUILDERTAG as null and does not request user input.
There still exists issue #944 for python dockerfiles. But the fix for that would best come from a modification to the draft binary itself.