Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now accepts different orbit epochs and origins #9

Merged
merged 8 commits into from
Aug 14, 2024
Merged

Conversation

akoumjian
Copy link
Contributor

Fixes ADAM-464

Can now handle orbits with distinct epochs. Also does some additional work to ensure original orbit origins are maintained.

Copy link

github-actions bot commented Aug 7, 2024

Pull Request Test Coverage Report for Build 10389496890

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 14 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+5.2%) to 91.192%

Files with Coverage Reduction New Missed Lines %
adam_core/propagator/adam_assist.py 14 91.19%
Totals Coverage Status
Change from base Build 10204093680: 5.2%
Covered Lines: 176
Relevant Lines: 193

💛 - Coveralls

Copy link
Member

@ntellis ntellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I'm thinking because of the epoch/origin_code loops and subsequent concatenation in _propagate_orbits, we don't guarantee the same sort order for the returned, propagated orbits?

tests/test_propagate.py Show resolved Hide resolved
@akoumjian
Copy link
Contributor Author

Looks good to me.

I'm thinking because of the epoch/origin_code loops and subsequent concatenation in _propagate_orbits, we don't guarantee the same sort order for the returned, propagated orbits?

Sort order is not preserved, and the top level propagator method actually explicitly sorts by orbit_id and then time.
I think this makes sense since you are often not getting back an equal number of orbits, preserving order is a little nonsensical. I guess we could order the orbit ids same as they were sent in.

@akoumjian akoumjian merged commit bb66d79 into main Aug 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants