-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Now accepts different orbit epochs and origins #9
Conversation
Pull Request Test Coverage Report for Build 10389496890Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I'm thinking because of the epoch/origin_code loops and subsequent concatenation in _propagate_orbits, we don't guarantee the same sort order for the returned, propagated orbits?
Sort order is not preserved, and the top level propagator method actually explicitly sorts by orbit_id and then time. |
Fixes ADAM-464
Can now handle orbits with distinct epochs. Also does some additional work to ensure original orbit origins are maintained.