Update to work on Julia 1.9 #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, really bringing this one back from the grave, @blakejohnson! Thanks! QGL.jl and pyQGL have significantly diverged with how the channel library is defined and used (it's a sqlite database now...), so I'm not sure what the right move is for thr future of QGL.jl. @grahamrow any thoughts? This might be a good jumping off point for the lower level language/IR we've been talking about as we get ready for the APS4... |
|
Understood. I think if you want to actually use this, you would need to update how it deals with channel libraries. For my purposes, I just wanted to create a speed benchmark, and so the old YAML format was sufficient. |
NOTE: These changes haven't been tested with hardware. I merely found several examples where the code would not terminate because of how various indices were being tracked. So, these changes are sufficient to get the code to terminate.
blakejohnson
force-pushed
the
feature/julia-1.9
branch
from
405e1dd to
be936e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I embarked on this before realizing that @matthewware had already done basically the same thing in #31. This doesn't include the updates he has to the APS file format, or the start he made to support bbndb.